More compact number operations

Doka-NT · Oct 9, 2015 · 4ecafe6 · 4ecafe6
1 parent b65bfad
commit 4ecafe6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/framework/captcha/CaptchaAction.php b/framework/captcha/CaptchaAction.php
@@ -184,7 +184,7 @@ public function validate($input, $caseSensitive)
         $session = Yii::$app->getSession();
         $session->open();
         $name = $this->getSessionKey() . 'count';
-        $session[$name] = $session[$name] + 1;
+        $session[$name] += 1;
         if ($valid || $session[$name] > $this->testLimit && $this->testLimit > 0) {
             $this->getVerifyCode(true);
         }

diff --git a/framework/helpers/BaseVarDumper.php b/framework/helpers/BaseVarDumper.php
@@ -231,7 +231,7 @@ private static function exportClosure(\Closure $closure)
             return 'function() {/* Error: unable to determine Closure source */}';
         }
 
-        $start = $start - 1;
+        --$start;
 
         $source = implode("\n", array_slice(file($fileName), $start, $end - $start));
         $tokens = token_get_all('<?php ' . $source);

diff --git a/framework/i18n/Formatter.php b/framework/i18n/Formatter.php
@@ -883,7 +883,7 @@ public function asPercent($value, $decimals = null, $options = [], $textOptions
             if ($decimals === null) {
                 $decimals = 0;
             }
-            $value = $value * 100;
+            $value *= 100;
             return number_format($value, $decimals, $this->decimalSeparator, $this->thousandSeparator) . '%';
         }
     }
@@ -1137,7 +1137,7 @@ private function formatSizeNumber($value, $decimals, $options, $textOptions)
             if (abs($value) < $this->sizeFormatBase) {
                 break;
             }
-            $value = $value / $this->sizeFormatBase;
+            $value /= $this->sizeFormatBase;
             $position++;
         } while ($position < 5);