Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lxml qname in argument #414

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

leon1995
Copy link
Member

@leon1995 leon1995 commented Mar 6, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

@leon1995 leon1995 requested a review from a-kleinf March 6, 2025 08:30
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 95.52239% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (17d57db) to head (d53a8e3).

Files with missing lines Patch % Lines
src/sdc11073/namespaces.py 96.00% 2 Missing ⚠️
src/sdc11073/xml_types/pm_types.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files         125      125           
  Lines       14700    14701    +1     
=======================================
+ Hits        13358    13359    +1     
  Misses       1342     1342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant