qt4: fix memory leak (allocate only when needed)

DreadSteel99 · Dec 16, 2013 · d6aa5c4 · d6aa5c4
1 parent d052232
commit d6aa5c4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/modules/gui/qt4/dialogs/toolbar.cpp b/modules/gui/qt4/dialogs/toolbar.cpp
@@ -555,10 +555,6 @@ void DroppingController::createAndAddWidget( QBoxLayout *newControlLayout,
                                              buttonType_e i_type,
                                              int i_option )
 {
-    doubleInt *value = new doubleInt;
-    value->i_type = i_type;
-    value->i_option = i_option;
-
     /* Special case for SPACERS, who aren't QWidgets */
     if( i_type == WIDGET_SPACER || i_type == WIDGET_SPACER_EXTEND )
     {
@@ -628,6 +624,10 @@ void DroppingController::createAndAddWidget( QBoxLayout *newControlLayout,
     /* QList and QBoxLayout don't act the same with insert() */
     if( i_index < 0 ) i_index = newControlLayout->count() - 1;
 
+    doubleInt *value = new doubleInt;
+    value->i_type = i_type;
+    value->i_option = i_option;
+
     widgetList.insert( i_index, value );
 }