Check explicitly for None value in Overkiz integration (home-assistan…

…t#65045)
DreamXiaoHai · Jan 28, 2022 · 2ff8f10 · 2ff8f10
1 parent 0604185
commit 2ff8f10
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/homeassistant/components/overkiz/cover_entities/awning.py b/homeassistant/components/overkiz/cover_entities/awning.py
@@ -48,7 +48,8 @@ def current_cover_position(self) -> int | None:
 
         None is unknown, 0 is closed, 100 is fully open.
         """
-        if current_position := self.executor.select_state(OverkizState.CORE_DEPLOYMENT):
+        current_position = self.executor.select_state(OverkizState.CORE_DEPLOYMENT)
+        if current_position is not None:
             return cast(int, current_position)
 
         return None

diff --git a/homeassistant/components/overkiz/cover_entities/generic_cover.py b/homeassistant/components/overkiz/cover_entities/generic_cover.py
@@ -51,9 +51,10 @@ def current_cover_tilt_position(self) -> int | None:
 
         None is unknown, 0 is closed, 100 is fully open.
         """
-        if position := self.executor.select_state(
+        position = self.executor.select_state(
             OverkizState.CORE_SLATS_ORIENTATION, OverkizState.CORE_SLATE_ORIENTATION
-        ):
+        )
+        if position is not None:
             return 100 - cast(int, position)
 
         return None

diff --git a/homeassistant/components/overkiz/light.py b/homeassistant/components/overkiz/light.py
@@ -79,8 +79,9 @@ def rgb_color(self) -> tuple[int, int, int] | None:
     @property
     def brightness(self) -> int | None:
         """Return the brightness of this light (0-255)."""
-        if brightness := self.executor.select_state(OverkizState.CORE_LIGHT_INTENSITY):
-            return round(cast(int, brightness) * 255 / 100)
+        value = self.executor.select_state(OverkizState.CORE_LIGHT_INTENSITY)
+        if value is not None:
+            return round(cast(int, value) * 255 / 100)
 
         return None