error attached directly to constructor instead of returned

DubFriend · Jun 4, 2014 · 9dddb80 · 9dddb80
1 parent 142c8b6
commit 9dddb80
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/mysql-wrap.js b/mysql-wrap.js
@@ -13,12 +13,12 @@ var MySQLWrapError = function (error) {
 };
 MySQLWrapError.prototype = Object.create(Error.prototype);
 
-module.exports = function (connection) {
+var createMySQLWrap = function (connection) {
     'use strict';
 
     var self = {};
 
-    self.Error = MySQLWrapError;
+    // self.Error = MySQLWrapError;
 
     var promiseRespond = function (def, err, res) {
         if(err) {
@@ -44,7 +44,7 @@ module.exports = function (connection) {
     };
 
     var respond = function (def, callback, err, res) {
-        var wrappedError = isMysqlError(err) ? new self.Error(err) : err;
+        var wrappedError = isMysqlError(err) ? new MySQLWrapError(err) : err;
         callback(wrappedError, res);
         promiseRespond(def, wrappedError, res);
     };
@@ -250,3 +250,7 @@ module.exports = function (connection) {
 
     return self;
 };
+
+createMySQLWrap.Error = MySQLWrapError;
+
+module.exports = createMySQLWrap;
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "mysql-wrap",
-  "version": "0.2.3",
+  "version": "0.3.0",
   "description": "Mysql interface and helper functions, wrapping node-mysql",
   "main": "mysql-wrap.js",
   "scripts": {

diff --git a/test.js b/test.js
@@ -316,7 +316,7 @@ exports.unique_constraint_error = function (test) {
     var self = this;
     self.sql.insert('table', { unique: 'a'})
     .catch(function (err) {
-        test.ok(err instanceof self.sql.Error);
+        test.ok(err instanceof createNodeMySQL.Error);
         test.strictEqual(err.code, 'ER_DUP_ENTRY', 'error code');
         test.strictEqual(err.indexName, 'unique', 'index name');
         test.done();