Skip to content

Commit

Permalink
change wording of the edit homepage button
Browse files Browse the repository at this point in the history
test plan (with draft state enabled):
 * navigate to the course home page
   - the button should now read 'Choose Home Page'
 * click the 'Choose Home Page' button
   - the dialog title should read 'Choose Home Page'
 * confirming the dialog should correctly change the home page

fixes CNVS-12128

Change-Id: Ic1088ad1335c1288f4a5a9721bdb62c6c95f5ad6
Reviewed-on: https://gerrit.instructure.com/34738
Reviewed-by: Jeremy Stanley <[email protected]>
QA-Review: Clare Strong <[email protected]>
Tested-by: Jenkins <[email protected]>
Product-Review: Mark Severson <[email protected]>
  • Loading branch information
miquella committed May 16, 2014
1 parent e1cd2b5 commit cd0ef4f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/views/courses/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
<div class="course-options">
<% if @can_manage_content %>
<a class="button-sidebar-wide element_toggler" aria-controls="edit_course_home_content_form" href="<%= context_url(@context, :context_details_url) %>">
<i class="icon-edit"></i>
<%= t('links.edit_homepage', %{Edit Homepage}) %>
<i class="icon-target"></i>
<%= t('links.choose_home_page', %{Choose Home Page}) %>
</a>
<% end %>

Expand Down Expand Up @@ -144,7 +144,7 @@
<% content_for :right_side do %>
<div id="edit_course_home_content" style="display: none;">
<h2><%= t('draft_state.headings.set_layout', %{Set Home Page Layout}) %></h2>
<%= form_for :course, :url => context_url(@context, :context_url), :html => {:tabindex=>"0", :'data-turn-into-dialog'=>'{"height": 300, "width":500,"modal":true}', :title=>t('headings.edit_homepage_title', %{Edit Homepage}), :style => "display:none", :id => "edit_course_home_content_form", :method => :put} do |f| %>
<%= form_for :course, :url => context_url(@context, :context_url), :html => {:tabindex=>"0", :'data-turn-into-dialog'=>'{"height": 300, "width":500,"modal":true}', :title=>t('headings.choose_home_page_title', %{Choose Home Page}), :style => "display:none", :id => "edit_course_home_content_form", :method => :put} do |f| %>
<label for="edit_course_home_content_select"><%= t('draft_state.labels.select_content', %{Select what you'd like to display on the homepage.}) %></label>
<br>
<select name="course[default_view]" id="edit_course_home_content_select">
Expand Down

0 comments on commit cd0ef4f

Please sign in to comment.