Fix SockJS when using the desktop client (smogon#1360)

* Patch SockJS v1.4.0 to work with nw.js

* Document how to upgrade SockJS in UPGRADING-SOCKJS.md

UPGRADING-SOCKJS.md

@@ -0,0 +1,15 @@
+Upgrading SockJS
+=======================================================================
+
+When SockJS needs to be upgraded, you will also need to patch it to work
+properly with nw.js. In the minified script, replace all instances of this:
+
+```javascript
+.call(this,"undefined"!=typeof global?global:"undefined"!=typeof self?self:"undefined"!=typeof window?window:{})
+```
+
+With this:
+
+```javascript
+.call(this,window)
+```

index.template.html

@@ -120,7 +120,7 @@ <h3><button class="closebutton" tabindex="-1"><i class="fa fa-times-circle"></i>
 <script src="//play.pokemonshowdown.com/data/pokedex-mini.js?"></script>
 <script src="//play.pokemonshowdown.com/data/typechart.js?"></script>
 <script src="//play.pokemonshowdown.com/js/battle.js?"></script>
-<script src="//play.pokemonshowdown.com/js/lib/sockjs-1.4.0.min.js"></script>
+<script src="//play.pokemonshowdown.com/js/lib/sockjs-1.4.0-nwjsfix.min.js"></script>
 <script src="//play.pokemonshowdown.com/js/lib/color-thief.min.js"></script>
 
 <script>

preactalpha.template.html

@@ -55,7 +55,7 @@ <h3><button class="closebutton" tabindex="-1" aria-label="Close"><i class="fa fa
 
 	<script defer src="/js/battle-dex.js?"></script>
 	<script defer src="/js/client-main.js?"></script>
-	<script defer src="/js/lib/sockjs-1.4.0.min.js?"></script>
+	<script defer src="/js/lib/sockjs-1.4.0-nwjsfix.min.js?"></script>
 	<script defer src="/js/client-connection.js?"></script>
 	<script defer src="/js/lib/preact.min.js?"></script>
 	<script defer src="/js/panels.js?"></script>

testclient-beta.html

@@ -56,7 +56,7 @@ <h3><button class="closebutton" tabindex="-1" aria-label="Close"><i class="fa fa
 
 	<script src="js/battle-dex.js"></script>
 	<script src="js/client-main.js"></script>
-	<script src="js/lib/sockjs-1.4.0.min.js"></script>
+	<script src="js/lib/sockjs-1.4.0-nwjsfix.min.js"></script>
 	<script src="js/client-connection.js"></script>
 	<script src="js/lib/preact.min.js"></script>
 	<script src="js/panels.js"></script>

testclient.html

@@ -90,7 +90,7 @@ <h3><button class="closebutton" tabindex="-1" aria-label="Close"><i class="fa fa
 		<script src="data/pokedex-mini-bw.js" onerror="loadRemoteData(this.src)"></script>
 		<script src="data/typechart.js" onerror="loadRemoteData(this.src)"></script>
 		<script src="js/battle.js"></script>
-		<script src="js/lib/sockjs-1.4.0.min.js"></script>
+		<script src="js/lib/sockjs-1.4.0-nwjsfix.min.js"></script>
 		<script src="js/lib/color-thief.min.js"></script>
 
 		<script>