user selector: MDL-16996- followup - change optgroup label escaping f…

…unciton to keep Nicolas Martignoni happy. I can's say I full understand this issue.
Eamon · Nov 3, 2008 · 71ef682 · 71ef682
1 parent 1e08b5c
commit 71ef682
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/user/selector/lib.php b/user/selector/lib.php
@@ -427,7 +427,7 @@ protected function output_options($groupedusers, $search) {
      */
     protected function output_optgroup($groupname, $users, $select) {
         if (!empty($users)) {
-            $output = '  <optgroup label="' . s($groupname) . ' (' . count($users) . ')">' . "\n";
+            $output = '  <optgroup label="' . htmlspecialchars($groupname) . ' (' . count($users) . ')">' . "\n";
             foreach ($users as $user) {
                 $attributes = '';
                 if (!empty($user->disabled)) {
@@ -440,7 +440,7 @@ protected function output_optgroup($groupname, $users, $select) {
                         $this->output_user($user) . "</option>\n";
             }
         } else {
-            $output = '  <optgroup label="' . s($groupname) . '">' . "\n";
+            $output = '  <optgroup label="' . htmlspecialchars($groupname) . '">' . "\n";
             $output .= '    <option disabled="disabled">&nbsp;</option>' . "\n";
         }
         $output .= "  </optgroup>\n";