MDL-15246 moving all remaining ddl function to adminlib, keeping old …

…lib/ddllib.php only for BC withexisting code; fixed inline docs related to ddl
Eamon · Jun 15, 2008 · b1f93b1 · b1f93b1
1 parent e81ebb9
commit b1f93b1
Show file tree

Hide file tree

Showing 61 changed files with 406 additions and 420 deletions.
diff --git a/admin/blocks.php b/admin/blocks.php
@@ -6,7 +6,6 @@
     require_once($CFG->libdir.'/adminlib.php');
     require_once($CFG->libdir.'/blocklib.php');
     require_once($CFG->libdir.'/tablelib.php');
-    require_once($CFG->libdir.'/ddllib.php');
 
     admin_externalpage_setup('manageblocks');
 

diff --git a/admin/cliupgrade.php b/admin/cliupgrade.php
@@ -717,7 +717,6 @@
 
     require_once(dirname(dirname(__FILE__)) . '/config.php');
     require_once($CFG->libdir.'/adminlib.php');  // Contains various admin-only functions
-    require_once($CFG->libdir.'/ddllib.php'); // Install/upgrade related db functions
 
     /**
      * @todo check upgrade status, if upgrader is running already, notify user and exit. 

diff --git a/admin/index.php b/admin/index.php
@@ -23,7 +23,6 @@
 
     require_once('../config.php');
     require_once($CFG->libdir.'/adminlib.php');  // Contains various admin-only functions
-    require_once($CFG->libdir.'/ddllib.php'); // Install/upgrade related db functions
     require_once($CFG->libdir.'/db/upgradelib.php');  // Upgrade-related functions
 
     $id             = optional_param('id', '', PARAM_TEXT);

diff --git a/admin/modules.php b/admin/modules.php
@@ -5,7 +5,6 @@
     require_once('../course/lib.php');
     require_once($CFG->libdir.'/adminlib.php');
     require_once($CFG->libdir.'/tablelib.php');
-    require_once($CFG->libdir.'/ddllib.php');
 
     // defines
     define('MODULE_TABLE','module_administration_table');

diff --git a/admin/xmldb/actions/check_bigints/check_bigints.class.php b/admin/xmldb/actions/check_bigints/check_bigints.class.php
@@ -81,9 +81,6 @@ function invoke() {
         $dbman = $DB->get_manager();
         $dbfamily = $DB->get_dbfamily();
 
-    /// And we nedd some ddl suff
-        require_once ($CFG->libdir . '/ddllib.php');
-
     /// Here we'll acummulate all the wrong fields found
         $wrong_fields = array();
 

diff --git a/admin/xmldb/actions/check_defaults/check_defaults.class.php b/admin/xmldb/actions/check_defaults/check_defaults.class.php
@@ -79,7 +79,6 @@ function invoke() {
         global $CFG, $XMLDB, $DB;
 
     /// And we nedd some ddl suff
-        require_once ($CFG->libdir . '/ddllib.php');
         $dbman = $DB->get_manager();
 
     /// Here we'll acummulate all the wrong fields found

diff --git a/admin/xmldb/actions/check_indexes/check_indexes.class.php b/admin/xmldb/actions/check_indexes/check_indexes.class.php
@@ -78,9 +78,6 @@ function invoke() {
 
         $dbman = $DB->get_manager();
 
-    /// And we nedd some ddl suff
-        require_once ($CFG->libdir . '/ddllib.php');
-
     /// Here we'll acummulate all the missing indexes found
         $missing_indexes = array();
 

diff --git a/admin/xmldb/index.php b/admin/xmldb/index.php
@@ -50,7 +50,6 @@
 /// getting "incomplete" objects
     require_once('../../config.php');
     require_once($CFG->libdir.'/adminlib.php');
-    require_once($CFG->libdir.'/ddllib.php'); // Install/upgrade related db functions
 
     admin_externalpage_setup('xmldbeditor');
 

diff --git a/backup/db/upgrade.php b/backup/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_backup_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_backup_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/activity_modules/db/upgrade.php b/blocks/activity_modules/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_activity_modules_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_activity_modules_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/admin/db/upgrade.php b/blocks/admin/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_admin_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_admin_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/calendar_month/db/upgrade.php b/blocks/calendar_month/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_calendar_month_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_calendar_month_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/calendar_upcoming/db/upgrade.php b/blocks/calendar_upcoming/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_calendar_upcoming_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_calendar_upcoming_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/course_list/db/upgrade.php b/blocks/course_list/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_course_list_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_course_list_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/course_summary/db/upgrade.php b/blocks/course_summary/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_course_summary_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_course_summary_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/db/upgrade.php b/blocks/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_blocks_upgrade($oldversion=0) {
 
@@ -31,7 +31,7 @@ function xmldb_blocks_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     if ($result && $oldversion < 2007081300) {

diff --git a/blocks/news_items/db/upgrade.php b/blocks/news_items/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_news_items_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_news_items_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/online_users/db/upgrade.php b/blocks/online_users/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_online_users_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_online_users_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/participants/db/upgrade.php b/blocks/participants/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_participants_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_participants_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/recent_activity/db/upgrade.php b/blocks/recent_activity/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_recent_activity_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_recent_activity_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/rss_client/db/upgrade.php b/blocks/rss_client/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_rss_client_upgrade($oldversion=0) {
 

diff --git a/blocks/search/db/upgrade.php b/blocks/search/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_search_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_search_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
 //===== 1.9.0 upgrade line ======//

diff --git a/blocks/search_forums/db/upgrade.php b/blocks/search_forums/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_search_forums_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_search_forums_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/section_links/db/upgrade.php b/blocks/section_links/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_section_links_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_section_links_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/blocks/social_activities/db/upgrade.php b/blocks/social_activities/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_block_social_activities_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_block_social_activities_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/enrol/authorize/db/upgrade.php b/enrol/authorize/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_enrol_authorize_upgrade($oldversion=0) {
 

diff --git a/enrol/paypal/db/upgrade.php b/enrol/paypal/db/upgrade.php
@@ -15,7 +15,7 @@
 // will tell you what you need to do.
 //
 // The commands in here will all be database-neutral,
-// using the functions defined in lib/ddllib.php
+// using the methods of database_manager class
 
 function xmldb_enrol_paypal_upgrade($oldversion=0) {
 
@@ -29,7 +29,7 @@ function xmldb_enrol_paypal_upgrade($oldversion=0) {
 /// upgrade code.
 
 /// if ($result && $oldversion < YYYYMMDD00) { //New version in version.php
-///     $result = result of "/lib/ddllib.php" function calls
+///     $result = result of database_manager methods
 /// }
 
     return $result;

diff --git a/lib/accesslib.php b/lib/accesslib.php
@@ -5125,7 +5125,6 @@ function component_level_changed($cap, $comp, $contextlevel) {
  */
 function build_context_path($force=false) {
     global $CFG, $DB;
-    require_once($CFG->libdir.'/ddllib.php');
 
     // System context
     $sitectx = get_system_context(!$force);