Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new api for Layouts #451

Merged
merged 1 commit into from
Sep 25, 2024
Merged

new api for Layouts #451

merged 1 commit into from
Sep 25, 2024

Conversation

GunkaArtur
Copy link
Contributor

Related issue: #446

@GunkaArtur GunkaArtur self-assigned this Sep 23, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
brizy-editor-page-demo 🛑 Canceled (Inspect) Sep 25, 2024 1:02pm
brizy-editor-popup-demo 🛑 Canceled (Inspect) Sep 25, 2024 1:02pm
brizy-editor-story-demo 🛑 Canceled (Inspect) Sep 25, 2024 1:02pm
brizy-local-editor-react 🛑 Canceled (Inspect) Sep 25, 2024 1:02pm
cms-integration-mongodb-atlas 🛑 Canceled (Inspect) Sep 25, 2024 1:02pm
netlify-marketing-page 🛑 Canceled (Inspect) Sep 25, 2024 1:02pm
render-marketing-page ❌ Failed (Inspect) Sep 25, 2024 1:02pm
shopify-headless-storefront 🛑 Canceled (Inspect) Sep 25, 2024 1:02pm
vercel-marketing-page 🛑 Canceled (Inspect) Sep 25, 2024 1:02pm

@GunkaArtur GunkaArtur linked an issue Sep 23, 2024 that may be closed by this pull request
Fix api for Layouts #446
Closed
Base automatically changed from 443-blocksAPI to new-builder September 24, 2024 07:13
@GunkaArtur GunkaArtur added the review Run PR Tests label Sep 25, 2024
maxval1
maxval1 reviewed Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@maxval1 maxval1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all console.log()

packages/core/src/core.ts Outdated
@@ -177,6 +191,7 @@ export const Core: Init<HtmlOutputType> = (token, config, cb) => {

try {
const action = JSON.parse(data.data);
console.log("action", action);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

demo/react/src/Editor.tsx Outdated
categories: convertToCategories(data.categories),
};

console.log("result", result);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@maxval1 maxval1 mentioned this pull request Sep 25, 2024
Closed
@GunkaArtur GunkaArtur added review Run PR Tests and removed review Run PR Tests labels Sep 25, 2024
@maxval1 maxval1 merged commit 0f4c8e7 into new-builder Sep 25, 2024
2 of 11 checks passed
@maxval1 maxval1 deleted the 446-layoutsAPI branch September 25, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxval1 maxval1 maxval1 left review comments

Assignees

@GunkaArtur GunkaArtur

Labels
review Run PR Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix api for Layouts
2 participants
@GunkaArtur @maxval1