feat(server): server, server-core, server-plugins #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nessunskill
force-pushed
the
25598-server
branch
6 times, most recently
from
58e9f05 to
55c9082
Compare
Nessunskill
force-pushed
the
25598-server
branch
from
55c9082 to
a631d1f
Compare
Nessunskill
added
review
Nessunskill
force-pushed
the
25598-server
branch
from
a631d1f to
ee2953c
Compare
Nessunskill
added
review
Nessunskill
force-pushed
the
25598-server
branch
from
ee2953c to
66518cb
Compare
Nessunskill
added
review
Nessunskill
force-pushed
the
25598-server
branch
from
66518cb to
406444e
Compare
Nessunskill
added
review
Nessunskill
force-pushed
the
25598-server
branch
from
406444e to
42237f9
Compare
Nessunskill
force-pushed
the
25598-server
branch
from
42237f9 to
80be208
Compare
Nessunskill
added
review
Nessunskill
force-pushed
the
25598-server
branch
from
80be208 to
b52a773
Compare
Nessunskill
added
review
maxval1
requested changes
Mar 5, 2024
coreServer/src/core/index.ts
Outdated
Comment on lines
50
to
64
| public registerPluginRoutesX( | ||
| pluginName: string, | ||
| path: string, | ||
| router: Router | ||
| ) { | ||
| this.routeHandlers.push({ pluginName, path, router }); | ||
| } | ||
|
|
||
| public registerPluginX(plugin: AbstractPlugin) { | ||
| plugin.initialize(); | ||
|
|
||
| if (typeof plugin.registerRoutes === "function") { | ||
| plugin.registerRoutes(this); | ||
| } | ||
| } |
coreServer/src/core/index.ts
Outdated
|
|
||
| this.app = express(); | ||
|
|
||
| this.app.use(cors()); |
There was a problem hiding this comment.
need to expose api for router
Comment on lines
14
to
17
| // Define register routes method | ||
| public registerRoutes(core: Core) { | ||
| console.log("Not implemented", core); | ||
| } |
coreServer/src/types/type.ts
Outdated
| import { Router } from "express"; | ||
|
|
||
| export enum ActionTypes { | ||
| "INIT_APP" = "INIT_APP", |
server/.eslintrc.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| module.exports = { | |||
Nessunskill
force-pushed
the
25598-server
branch
2 times, most recently
from
65b285e to
4410c6e
Compare
Nessunskill
added
review
Nessunskill
force-pushed
the
25598-server
branch
from
4410c6e to
b5743c2
Compare
Nessunskill
added
review
Nessunskill
force-pushed
the
25598-server
branch
from
b5743c2 to
8859495
Compare
Nessunskill
added
review
maxval1
added
review
maxval1
added
review
maxval1
added
review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.