mgr/telemetry: reset health warning after re-opting-in

When telemetry requires re-opting-in (either whenever new collections which require nagging are available, or on major upgrades) a health warning is set by the module. This health warning should be reset once the user re-opts-in (with `ceph telemetry on`), but currently it might take longer. Fixing it here by waking up serve() immediately after re-opting-in, which will invoke refreshing health checks. Fixes: https://tracker.ceph.com/issues/56486 Signed-off-by: Yaarit Hatuka <[email protected]>
Ederpoll · Jul 22, 2022 · cfcb0dc · cfcb0dc
1 parent d9f4d18
commit cfcb0dc
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/pybind/mgr/telemetry/module.py b/src/pybind/mgr/telemetry/module.py
@@ -1579,6 +1579,9 @@ def on(self, license: Optional[str] = None) -> Tuple[int, str, str]:
                 msg = f"{msg}\nSome channels are disabled, please enable with:\n"\
                         f"`ceph telemetry enable channel{disabled_channels}`"
 
+            # wake up serve() to reset health warning
+            self.event.set()
+
             return 0, msg, ''
 
     @CLICommand('telemetry off')