Skip to content

Commit

Permalink
Add missing virtual destructors to virtual classes (flutter#4083)
Browse files Browse the repository at this point in the history
These were previously undetected because Wdelete-non-virtual-dtor
didn't work with std::unique_ptr, but that's no longer the case.
  • Loading branch information
petrhosek authored Sep 9, 2017
1 parent 0558644 commit 51f1260
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions flow/process_info.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ namespace flow {
/// can choose to provide this information however.
class ProcessInfo {
public:
virtual ~ProcessInfo() = default;

virtual bool SampleNow() = 0;

/// Virtual memory size in bytes.
Expand Down
2 changes: 2 additions & 0 deletions flow/scene_update_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ class SceneUpdateContext {

class SurfaceProducer {
public:
virtual ~SurfaceProducer() = default;

virtual std::unique_ptr<SurfaceProducerSurface> ProduceSurface(
const SkISize& size) = 0;

Expand Down
2 changes: 2 additions & 0 deletions vulkan/vulkan_native_surface.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ namespace vulkan {

class VulkanNativeSurface {
public:
virtual ~VulkanNativeSurface() = default;

virtual const char* GetExtensionName() const = 0;

virtual uint32_t GetSkiaExtensionName() const = 0;
Expand Down

0 comments on commit 51f1260

Please sign in to comment.