Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #ESPP-271 - Clean build and docker to launch pwa without problems #84

Merged
merged 5 commits into from
Jun 15, 2022
Merged

feat: #ESPP-271 - Clean build and docker to launch pwa without problems #84

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42c0fc7
feat: #ESPP-271 - Clean build and docker to launch pwa without problems
Jun 9, 2022
c6df288
feat: #ESPP-271 - Reset NEXT_TELEMETRY_DISABLED
Jun 13, 2022
4d270e1
chore: #ESPP-271 - comment instead of remove to explain for futur dev…
Jun 13, 2022
5d1aa2f
Merge branch 'master' into feat/ESPP-271-part-2-clean-and-build
thibaut-boudier Jun 14, 2022
942220f
Merge branch 'master' into feat/ESPP-271-part-2-clean-and-build
thibaut-boudier Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pwa/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ENV NEXT_TELEMETRY_DISABLED 1

# prevent the reinstallation of node modules at every changes in the source code
COPY package.json yarn.lock ./
RUN yarn
thibaut-boudier marked this conversation as resolved.
Show resolved Hide resolved
RUN yarn install

COPY . ./

Expand All @@ -27,8 +27,9 @@ VOLUME /usr/src/pwa/node_modules
# depends on the "common" stage above
FROM api_platform_pwa_common AS api_platform_pwa_dev

ENV API_PLATFORM_CLIENT_GENERATOR_OUTPUT .
RUN yarn global add @api-platform/client-generator
# ENV API_PLATFORM_CLIENT_GENERATOR_OUTPUT .
# RUN yarn global add @api-platform/client-generator
# This part was removed as we don't use anymore api-platform, so it added bad configuration for next

CMD ["yarn", "dev"]

Expand Down
2 changes: 1 addition & 1 deletion pwa/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"scripts": {
"dev": "next dev",
"build": "next build && next export",
"build": "next build",
"start": "next start",
"test": "jest",
"eslint": "eslint --fix --max-warnings=0 --ignore-path .gitignore .",
Expand Down