docs: Update instructions to append rcN to release candidates
#8114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,7 +46,7 @@ Here's a checklist for the release process. | |||
| ## Releasing -rc2, ..., -rcN | |||
|
|
|||
| 1. Update CHANGELOG.md by changing rc(N-1) to rcN. Update the changelog list with information from newly merged PRs also. | |||
| 2. Update the package versions: `make update-versions NEW_VERSION=<VERSION>` | |||
| 2. Update the package versions: `make update-versions NEW_VERSION=<VERSION>-rcN` | |||
There was a problem hiding this comment.
Suggested change
| 2. Update the package versions: `make update-versions NEW_VERSION=<VERSION>-rcN` | |
| 2. Update the package versions: `make update-versions NEW_VERSION=<VERSION>rcN` |
Keep this consistent with the first one. Pyln-testing now looks for the hyphen as a separator for the commit hash, so probably better to leave it off.
ShahanaFarooqui
force-pushed
the
doc-append-rc-to-release-checklist
branch
from
dade17c to
6118a2c
Compare
Changelog-None. Update doc/contribute-to-core-lightning/release-checklist.md Co-Authored-By: Alex Myers <[email protected]>
ShahanaFarooqui
force-pushed
the
doc-append-rc-to-release-checklist
branch
from
6118a2c to
ee8c1a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-None.