make: remove old clnrest directory #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
clnrest-old-dir-rm
branch
from
9d82138 to
780ef61
Compare
Changelog-None
rustyrussell
force-pushed
the
clnrest-old-dir-rm
branch
from
780ef61 to
7940b56
Compare
|
ACK 7940b56 Tested this on Ubuntu Jammy and it removes the installed clnrest directory from v24.11 at install time as advertised. If fetching from the same build directory as used for <=24.11, we still need a |
This was referenced Apr 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since clnrest is no longer a python plugin it's old directory was not removed by the existing code and leads to an error when running
make installwhen upgrading to cln 25.02 from an older version that was previously installed.Users had to see the error during
make installand remove the directory themselves and runmake installagain to fix this. The PR hopefully takes care of that automatically.Fixes #8141
Don't know if it fixes the nix issue mentioned