Use buildSrc for Fest Assert Core

Reviewed By: defHLT Differential Revision: D23623704 fbshipit-source-id: a7117cbf0efd667dd5d1ce38aeded7815ee41fe0
Enerfek · Sep 11, 2020 · 22923e9 · 22923e9
1 parent 058e48a
commit 22923e9
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 9 deletions.
diff --git a/animated-base/build.gradle b/animated-base/build.gradle
@@ -29,7 +29,7 @@ dependencies {
     testImplementation project(':animated-base-test')
     testImplementation project(':imagepipeline-test')
     testImplementation TestDeps.junit
-    testImplementation "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
+    testImplementation TestDeps.festAssertCore
     testImplementation TestDeps.mockitoCore
     testImplementation("org.powermock:powermock-api-mockito2:${POWERMOCK_VERSION}") {
         exclude group: 'org.mockito', module: 'mockito-all'

diff --git a/animated-drawable/build.gradle b/animated-drawable/build.gradle
@@ -36,7 +36,7 @@ dependencies {
     testImplementation Deps.AndroidX.androidxAnnotation
     testImplementation Deps.jsr305
     testImplementation TestDeps.junit
-    testImplementation "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
+    testImplementation TestDeps.festAssertCore
     testImplementation TestDeps.mockitoCore
     testImplementation("org.powermock:powermock-api-mockito2:${POWERMOCK_VERSION}") {
         exclude group: 'org.mockito', module: 'mockito-all'

diff --git a/buildSrc/src/main/java/com/facebook/fresco/buildsrc/TestDeps.kt b/buildSrc/src/main/java/com/facebook/fresco/buildsrc/TestDeps.kt
@@ -12,4 +12,6 @@ object TestDeps {
     const val junit = "junit:junit:4.12"
 
     const val mockitoCore = "org.mockito:mockito-core:2.26.0"
+
+    const val festAssertCore = "org.easytesting:fest-assert-core:2.0M10"
 }
diff --git a/drawee-span/build.gradle b/drawee-span/build.gradle
@@ -21,7 +21,7 @@ dependencies {
     implementation project(':ui-common')
 
     testImplementation TestDeps.junit
-    testImplementation "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
+    testImplementation TestDeps.festAssertCore
     testImplementation TestDeps.mockitoCore
     testImplementation("org.robolectric:robolectric:${ROBOLECTRIC_VERSION}") {
         exclude group: 'commons-logging', module: 'commons-logging'

diff --git a/fbcore/build.gradle b/fbcore/build.gradle
@@ -20,7 +20,7 @@ dependencies {
     testImplementation project(':mockito-config')
     testImplementation Deps.jsr305
     testImplementation TestDeps.junit
-    testImplementation "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
+    testImplementation TestDeps.festAssertCore
     testImplementation TestDeps.mockitoCore
     testImplementation "org.powermock:powermock-api-mockito2:${POWERMOCK_VERSION}"
     testImplementation "org.powermock:powermock-module-junit4-rule:${POWERMOCK_VERSION}"

diff --git a/gradle.properties b/gradle.properties
@@ -26,7 +26,6 @@ android.useAndroidX=true
 android.enableJetifier=true
 
 # Deps for libraries
-FEST_ASSERT_CORE_VERSION=2.0M10
 POWERMOCK_VERSION=2.0.2
 ROBOLECTRIC_VERSION=4.3.1
 

diff --git a/imagepipeline-base/build.gradle b/imagepipeline-base/build.gradle
@@ -25,7 +25,7 @@ dependencies {
     testImplementation project(':imagepipeline-base-test')
     testImplementation TestDeps.junit
     testImplementation "org.assertj:assertj-core:${versions.assertjCore}"
-    testImplementation "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
+    testImplementation TestDeps.festAssertCore
     testImplementation TestDeps.mockitoCore
     testImplementation("org.powermock:powermock-api-mockito2:${POWERMOCK_VERSION}") {
         exclude group: 'org.mockito', module: 'mockito-all'

diff --git a/imagepipeline/build.gradle b/imagepipeline/build.gradle
@@ -31,7 +31,7 @@ dependencies {
     testImplementation project(':imagepipeline-base-test')
     testImplementation project(':native-imagetranscoder')
     testImplementation TestDeps.junit
-    testImplementation "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
+    testImplementation TestDeps.festAssertCore
     testImplementation TestDeps.mockitoCore
     testImplementation("org.powermock:powermock-api-mockito2:${POWERMOCK_VERSION}") {
         exclude group: 'org.mockito', module: 'mockito-all'

diff --git a/native-filters/build.gradle b/native-filters/build.gradle
@@ -32,7 +32,7 @@ dependencies {
     testImplementation "androidx.legacy:legacy-support-core-utils:${versions.androidx.legacy_support_core_utils}"
     testImplementation Deps.jsr305
     testImplementation TestDeps.junit
-    testImplementation "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
+    testImplementation TestDeps.festAssertCore
     testImplementation TestDeps.mockitoCore
     testImplementation("org.powermock:powermock-api-mockito2:${POWERMOCK_VERSION}") {
         exclude group: 'org.mockito', module: 'mockito-all'

diff --git a/native-imagetranscoder/build.gradle b/native-imagetranscoder/build.gradle
@@ -28,7 +28,7 @@ dependencies {
     testImplementation "androidx.legacy:legacy-support-core-utils:${versions.androidx.legacy_support_core_utils}"
     testImplementation Deps.jsr305
     testImplementation TestDeps.junit
-    testImplementation "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
+    testImplementation TestDeps.festAssertCore
     testImplementation TestDeps.mockitoCore
     testImplementation("org.powermock:powermock-api-mockito2:${POWERMOCK_VERSION}") {
         exclude group: 'org.mockito', module: 'mockito-all'