Skip to content

Commit

Permalink
Bump Flipper Min SDK to 21 (facebook#2742)
Browse files Browse the repository at this point in the history
Summary:
Getting this on CircleCI:

```
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':tools:flipper-fresco-plugin:processDebugAndroidTestManifest'.
> Manifest merger failed : uses-sdk:minSdkVersion 16 cannot be smaller than version 21 declared in library [:tools:flipper] /home/circleci/project/tools/flipper/build/intermediates/merged_manifest/debug/AndroidManifest.xml as the library might be using APIs not available in 16
        Suggestion: use a compatible library with a minSdk of at most 16,
                or increase this project's minSdk version to at least 21,
                or use tools:overrideLibrary="com.facebook.fresco.flipper" to force usage (may lead to runtime failures)
```

Pull Request resolved: facebook#2742

Reviewed By: oprisnik

Differential Revision: D49095049

Pulled By: passy

fbshipit-source-id: 58b55c5bf776ea4cd1ab63d0edadb82c9b278b9f
  • Loading branch information
passy authored and facebook-github-bot committed Sep 8, 2023
1 parent 09a0a5b commit 5168802
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ object FrescoConfig {

const val compileSdkVersion = 34
const val minSdkVersion = 21
const val flipperPluginMinSdkVersion = 16
const val vitoLithoMinSdkVersion = 16
const val flipperPluginMinSdkVersion = 21
const val vitoLithoMinSdkVersion = 21
const val samplesMinSdkVersion = 21
const val targetSdkVersion = 34
}

0 comments on commit 5168802

Please sign in to comment.