Skip to content

Commit

Permalink
Removes fishing minimum duration check (tgstation#69783)
Browse files Browse the repository at this point in the history
  • Loading branch information
AnturK authored Sep 9, 2022
1 parent 31e78df commit bf7c6e1
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions code/modules/fishing/fishing_minigame.dm
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
#define BITING_PHASE 2
// UI minigame phase
#define MINIGAME_PHASE 3
// Shortest time the minigame can be won
#define MINIMUM_MINIGAME_DURATION 140

/datum/fishing_challenge
/// When the ui minigame phase started
Expand Down Expand Up @@ -114,13 +112,6 @@
UnregisterSignal(used_rod, COMSIG_ITEM_DROPPED)
if(phase == MINIGAME_PHASE)
used_rod.consume_bait()
if(win)
// validate timings to have at least basic abuse prevention, though it's kinda impossible task here
// 140 from minimum completion bar fill time
var/minimum_time = start_time + MINIMUM_MINIGAME_DURATION
if(world.time < minimum_time)
win = FALSE
stack_trace("Fishing minimum time check failed")
if(win)
if(reward_path != FISHING_DUD)
playsound(lure, 'sound/effects/bigsplash.ogg', 100)
Expand Down Expand Up @@ -212,4 +203,3 @@
#undef WAIT_PHASE
#undef BITING_PHASE
#undef MINIGAME_PHASE
#undef MINIMUM_MINIGAME_DURATION

0 comments on commit bf7c6e1

Please sign in to comment.