Modify CSS Banners #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test and if possile make css banners use gulp-header-comment package instead of the gulp-replace package.
ErikSRoth
added
bug
|
gulp-header-comment pkg is not working as expected with PHP files. Looking for a plugin that will work properly with any file. |
|
Added gulp-banner pkg and adjusted code in relevant files for parsing PHP files. This module is working much better than the previous, and has been tested numerous times with the PHP dev build function. No issues or errors detected. Next we will work on modifying files fo JS dev files and see how well this pkg works for JS files. |
|
JS build scripts and banner modified to work with gulp-banner pkg. Tested with no issues or errors detected. Next: Fix SCSS --> CSS build files and banners. |
|
SCSS-->CSS build scripts modified to use gulp-banner. Everything works as should with no errors. |
This was
linked to
issues
Oct 19, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test and if possile make css banners use gulp-header-comment package instead of the gulp-replace package.