Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh now working differently #48

Closed
wants to merge 6 commits into from
Closed

build.sh now working differently #48

wants to merge 6 commits into from

Conversation

ann0see
Copy link
Collaborator

@ann0see ann0see commented May 10, 2017

Just create a new folder, add a config file and a conflicts file and run ./build.sh foldername and you´ll get a new gandalf version. Maybe incompatible with #47. @1Conan.

@ann0see
Copy link
Collaborator Author

ann0see commented May 10, 2017

Sorry for the "macOS fix" it's from 1Conan. Hopefully he's ok with it. (I'm using it here)

@1Conan
Copy link
Collaborator

1Conan commented May 10, 2017

This didn't totally follow the styleguide.
Also, using source isn't very portable.

@ann0see
Copy link
Collaborator Author

ann0see commented May 11, 2017

Feel free to improve it. (Also styling)

What do you mean by "not very portable"? Do you mean it only runs in bash? We could use awk I guess, but I don't know how to use it correctly.

I think this is a bit more user friendly, since you only have to create a new folder + a configuration file + conflictsfile
And then run build.sh with the right folder name and you have a new version of gandalf.
I could also remove the cd and specify the path everywhere where needed.

@ann0see ann0see closed this May 18, 2017
@ann0see ann0see deleted the configfile branch May 21, 2017 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants