Build.sh improvement

[ann0see]

Now you just have to execute ./build.sh versionfolder to create a new .deb. Basically just an improvement.
Tried fixing .DS_Store issues (delete all .DS_Store files in Gandalf folder in build.sh) but I need some confirmation by @mehulrao.

Several small improvements. Not only @1Conan 's improvements.
Will check if folder exists and files are present. You can argue about this, but it's just better to do so in my opinion.

[1Conan]

Style guide issues

Constants and most variables should be at top.
bash arg variables should be $1 not ${1}
the find command isn't an improvement. Actually made it a little worse. -exec rm {} is more portable.

[1Conan]

Nothing different with my find. You just changed -exec rm {}. -exec rm {} is actually much more recommended.

[ann0see]

Ok. Then I'll use your find.

[ann0see]

Question you use find . -type f -name '.DS_STORE' -exec rm {} +
What's the + for?

[1Conan]

https://google.github.io/styleguide/shell.xml

${1} should be $1.

Also, I believe you're declaring a variable.

[ann0see]

@1Conan ok. So I fixed many things. But I can't put all the constants / variables to the top: Otherwise there'll be some cat errors if I specify a nonexistent / invalid folder (surely cat can't find file or folder -> error). If it aborts before defining e.g. PKG_CONFLICTS there won't be these errors. It's just cosmetic… but if you have a better idea you can improve the branch.
Since I'm very new to all this: Why is e.g. Bold a variable? It is a constant for me (you will not change this e.g. why should I write something else in bold). And PKG_CONFLICTS would be a variable (not sure) Since in every new version this will contain an other value. But we don't change it in the script: so it could be a constant too? M

[ann0see]

Ok. He wants to merge into builds branch and not into master.

[ann0see]

@mehulrao: There´s something wrong with your App: If you compile Gandalf (102/x) via eg. Ubuntu there´ll be errors: there are then 2 Folders. One called Gandalf.app with capital G, and an other called gandalf.app with a lowercase g. So Ubuntu copies the Gandalf.app and if you install it on iOS the app won´t show. I´ll compile your app via my mac, and we´ll see what´s happening...

[ann0see]

Didn't compile your app. Just extracted it from a the latest official .deb.

There were some errors. Hopefully I squashed them now. One error I think we must discuss is this one:
Dpkg wants to remove /var/mobile/Downloads

[EthanRDoesMC]

That's a dpkg thing that dpkg does. If downloads were empty, it'd try to remove /mobile. Which it can't. Because there are things in it.

[EthanRDoesMC]

To build Gandalf, you need macOS or an OS that recognizes the .app extension in the same way. But since macOS is not preloaded with the stuff required to make it, there will need to be YET ANOTHER FREAKING SCRIPT (lol) to install the stuff on macOS.

[EthanRDoesMC]

I figure this is okay for tonight.

[ann0see]

I could build it on Ubuntu ;-). You just have to make sure that there's only a Gandalf.app folder.

[ann0see]

@ Everyone @EthanRDoesMC @mehulrao
Reminder:
Attention: syntax has changed: now you must cd to the folder where build.sh is and execute it with ./build.sh version:

./build.sh x will build GandalfX, ./build.sh 102 will build Gandalf102.
If you have more versions this will speed up compiling (you don't have to edit a file each time) you only run ./build.sh x && ./build.sh 102 && ./build.sh 103 && ./build.sh 933
And after some time you'll get everything compiled.
One thing to add: do we need the confirmation at the beginning?