Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when equipping Hardlight Shield with Good Ending mod #17

Closed
Goldenschmidt opened this issue Jan 29, 2023 · 1 comment
Closed

Crash when equipping Hardlight Shield with Good Ending mod #17

Goldenschmidt opened this issue Jan 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Goldenschmidt
Copy link

What happens?
Getting the Hardlight Shield into your inventory will crash your game, if you have Good Ending mod installed.

How do I cause it?
Have both the Ori mod and the Good Ending mod installed, and give yourself the Light Shield. Boom! Crash.

Is this bug so bad that you find it nearly impossible to play?
Nope. But the moment you acquire the shield, your own hope to get back into the save again would be to use the NBTEditor.

Log file
crash-2023-01-29_14.33.32-server.txt
crash-2023-01-29_14.33.35-client.txt

@EtiTheSpirit
Copy link
Owner

This is a bug in Good Ending itself. I have taken the liberty of moving this report to their repository on your behalf as I did some reading in their source code to isolate the cause with the help of your crash log. You can check the issue's status here: Good Ending :: Issue #7). As such, this issue will be closed.

After having a look at their source code, you should be able to bypass this issue by giving yourself a shield that has a tag on it. You can use the /give command like this to fix the bug: /give @s orimod:light_shield{Damage:0}

Admittedly, part of this issue is caused by the lack of a Damage field on the Hardlight Shield, which is part of why it is indestructible (adding the tag alone will not help). This will be fixed in the next update of my mod, but this is your workaround for now. I will file a new issue myself for this problem, so no worries about doing that.

@EtiTheSpirit EtiTheSpirit added the wontfix This will not be worked on label Jan 29, 2023
@EtiTheSpirit EtiTheSpirit closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants