s390/pkey: fix memory leak within _copy_apqns_from_user()

Fixes: f2bbc96 ("s390/pkey: add CCA AES cipher key support") Reported-by: Markus Elfring <[email protected]> Reported-by: Christian Borntraeger <[email protected]> Signed-off-by: Heiko Carstens <[email protected]> Signed-off-by: Vasily Gorbik <[email protected]>
EttusResearch · Nov 12, 2019 · f9cac4f · f9cac4f
1 parent 4ff4ba1
commit f9cac4f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/drivers/s390/crypto/pkey_api.c b/drivers/s390/crypto/pkey_api.c
@@ -740,8 +740,10 @@ static void *_copy_apqns_from_user(void __user *uapqns, size_t nr_apqns)
 		kapqns = kmalloc(nbytes, GFP_KERNEL);
 		if (!kapqns)
 			return ERR_PTR(-ENOMEM);
-		if (copy_from_user(kapqns, uapqns, nbytes))
+		if (copy_from_user(kapqns, uapqns, nbytes)) {
+			kfree(kapqns);
 			return ERR_PTR(-EFAULT);
+		}
 	}
 
 	return kapqns;