Skip to content

Commit

Permalink
Fix ESLint warnings and remove from ignore list (facebook#48291)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#48291

Changelog: [internal]

`react-native-fantom` was added to `.eslintignore` when we upgraded to React 19 because we wanted to reduce the amount of warnings to ease the migration.

This re-enables ESLint for that directory and removes the warnings.

Reviewed By: cipolleschi

Differential Revision: D67283104

fbshipit-source-id: 4ec2363ceaff3cd7bd6e5d70e9588c3dd22d7d85
  • Loading branch information
rubennorte authored and facebook-github-bot committed Dec 16, 2024
1 parent 92bffe6 commit 0658424
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ packages/react-native/ReactAndroid/build
packages/react-native/ReactAndroid/hermes-engine/build/
packages/react-native/Libraries/Renderer/*
packages/react-native/Libraries/vendor/**/*
packages/react-native-fantom/**/*
node_modules/
packages/*/node_modules
packages/*/dist
Expand Down
7 changes: 0 additions & 7 deletions packages/react-native-fantom/runtime/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ export type TestSuiteResult =
},
};

type SnapshotState = {
name: string,
snapshotResults: TestSnapshotResults,
};

let currentSnapshotState: SnapshotState;

const tests: Array<{
title: string,
ancestorTitles: Array<string>,
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-fantom/src/__tests__/Fantom-itest.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ describe('Fantom', () => {
});

// TODO: fix error handling and make this pass
// eslint-disable-next-line jest/no-disabled-tests
it.skip('should re-throw errors from the task synchronously', () => {
expect(() => {
runTask(() => {
Expand All @@ -51,6 +52,7 @@ describe('Fantom', () => {
});

// TODO: fix error handling and make this pass
// eslint-disable-next-line jest/no-disabled-tests
it.skip('should re-throw errors from microtasks synchronously', () => {
expect(() => {
runTask(() => {
Expand Down

0 comments on commit 0658424

Please sign in to comment.