Skip to content

Commit

Permalink
Register postgre driver in pkg/event/target (minio#6689)
Browse files Browse the repository at this point in the history
Commit 5c13765 removed postgre registration triggerd
by the automatic gofmt command but it was the only where pg is registered. This commit
fixes behavior and adds unit tests to check whether postgre & sql are registered or not.
  • Loading branch information
vadmeste authored and kannappanr committed Oct 23, 2018
1 parent 9631d65 commit e29009d
Show file tree
Hide file tree
Showing 30 changed files with 6,458 additions and 0 deletions.
37 changes: 37 additions & 0 deletions pkg/event/target/mysql_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*
* Minio Cloud Storage, (C) 2018 Minio, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package target

import (
"database/sql"
"testing"
)

// TestPostgreSQLRegistration checks if sql driver
// is registered and fails otherwise.
func TestMySQLRegistration(t *testing.T) {
var found bool
for _, drv := range sql.Drivers() {
if drv == "mysql" {
found = true
break
}
}
if !found {
t.Fatal("mysql driver not registered")
}
}
2 changes: 2 additions & 0 deletions pkg/event/target/postgresql.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ import (
"strings"
"time"

_ "github.com/lib/pq" // Register postgres driver

"github.com/minio/minio/pkg/event"
xnet "github.com/minio/minio/pkg/net"
)
Expand Down
37 changes: 37 additions & 0 deletions pkg/event/target/postgresql_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*
* Minio Cloud Storage, (C) 2018 Minio, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package target

import (
"database/sql"
"testing"
)

// TestPostgreSQLRegistration checks if postgres driver
// is registered and fails otherwise.
func TestPostgreSQLRegistration(t *testing.T) {
var found bool
for _, drv := range sql.Drivers() {
if drv == "postgres" {
found = true
break
}
}
if !found {
t.Fatal("postgres driver not registered")
}
}
29 changes: 29 additions & 0 deletions vendor/github.com/lib/pq/CONTRIBUTING.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions vendor/github.com/lib/pq/LICENSE.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

95 changes: 95 additions & 0 deletions vendor/github.com/lib/pq/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions vendor/github.com/lib/pq/TESTS.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e29009d

Please sign in to comment.