Skip to content

Commit

Permalink
cleanup(react): remove cra-to-nx package (nrwl#15556)
Browse files Browse the repository at this point in the history
leosvelperez authored Apr 12, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent d2f8555 commit 8562964
Showing 36 changed files with 1 addition and 1,073 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/e2e-matrix.yml
Original file line number Diff line number Diff line change
@@ -104,7 +104,6 @@ jobs:
project:
- e2e-angular-core
- e2e-angular-extensions
- e2e-cra-to-nx
- e2e-cypress
- e2e-detox
- e2e-esbuild
@@ -146,8 +145,6 @@ jobs:
codeowners: 'S04SS457V38'
- project: e2e-angular-extensions
codeowners: 'S04SS457V38'
- project: e2e-cra-to-nx
codeowners: 'S04TNCNJG5N'
- project: e2e-cypress
codeowners: 'S04T16BTJJY'
- project: e2e-detox
@@ -211,8 +208,6 @@ jobs:
project: e2e-angular-core
- node_version: 16
project: e2e-angular-extensions
- node_version: 16
project: e2e-cra-to-nx
- node_version: 16
project: e2e-cypress
- node_version: 16
@@ -261,8 +256,6 @@ jobs:
project: e2e-angular-core
- node_version: 19
project: e2e-angular-extensions
- node_version: 19
project: e2e-cra-to-nx
- node_version: 19
project: e2e-cypress
- node_version: 19
7 changes: 0 additions & 7 deletions .github/workflows/e2e-windows.yml
Original file line number Diff line number Diff line change
@@ -75,7 +75,6 @@ jobs:
project:
- e2e-angular-core
- e2e-angular-extensions
- e2e-cra-to-nx
- e2e-cypress
- e2e-esbuild
- e2e-jest
@@ -104,8 +103,6 @@ jobs:
codeowners: 'S04SS457V38'
- project: e2e-angular-extensions
codeowners: 'S04SS457V38'
- project: e2e-cra-to-nx
codeowners: 'S04TNCNJG5N'
- project: e2e-cypress
codeowners: 'S04T16BTJJY'
- project: e2e-esbuild
@@ -156,8 +153,6 @@ jobs:
project: e2e-angular-core
- node_version: 16
project: e2e-angular-extensions
- node_version: 16
project: e2e-cra-to-nx
- node_version: 16
project: e2e-cypress
- node_version: 16
@@ -200,8 +195,6 @@ jobs:
project: e2e-angular-core
- node_version: 19
project: e2e-angular-extensions
- node_version: 19
project: e2e-cra-to-nx
- node_version: 19
project: e2e-cypress
- node_version: 19
2 changes: 0 additions & 2 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -38,8 +38,6 @@ yarn.lock @FrozenPandaz @vsavkin @AgentEnder @jaysoo @JamesHenry
/e2e/react/** @jaysoo @mandarini @xiongemi @ndcunningham
/packages/next/** @ndcunningham @jaysoo @xiongemi
/e2e/next/** @ndcunningham @jaysoo @xiongemi
/packages/cra-to-nx/** @jaysoo @xiongemi @mandarini
/e2e/cra-to-nx/** @jaysoo @xiongemi @mandarini @ndcunningham
/packages/react/plugins/component-testing/** @jaysoo @ndcunningham @barbados-clemens
/packages/react/src/generators/cypress-component-configuration/** @jaysoo @ndcunningham @barbados-clemens
/packages/react/src/generators/component-test/** @jaysoo @ndcunningham @barbados-clemens
8 changes: 0 additions & 8 deletions docs/generated/manifests/menus.json
Original file line number Diff line number Diff line change
@@ -4102,14 +4102,6 @@
"isExternal": false,
"disableCollapsible": false
},
{
"id": "cra-to-nx",
"path": "/packages/cra-to-nx",
"name": "cra-to-nx",
"children": [],
"isExternal": false,
"disableCollapsible": false
},
{
"id": "create-nx-plugin",
"path": "/packages/create-nx-plugin",
12 changes: 0 additions & 12 deletions docs/generated/manifests/packages.json
Original file line number Diff line number Diff line change
@@ -369,18 +369,6 @@
},
"path": "/packages/angular"
},
"cra-to-nx": {
"githubRoot": "https://github.com/nrwl/nx/blob/master",
"name": "cra-to-nx",
"packageName": "cra-to-nx",
"description": "This package will turn your React app into an Nx workspace. To use this package, your React app must have been generated and kept the structure of Create-React-App, with files generated either in js/jsx or ts/tsx.",
"documents": {},
"root": "/packages/cra-to-nx",
"source": "/packages/cra-to-nx/src",
"executors": {},
"generators": {},
"path": "/packages/cra-to-nx"
},
"create-nx-plugin": {
"githubRoot": "https://github.com/nrwl/nx/blob/master",
"name": "create-nx-plugin",
11 changes: 0 additions & 11 deletions docs/generated/packages-metadata.json
Original file line number Diff line number Diff line change
@@ -368,17 +368,6 @@
"root": "/packages/angular",
"source": "/packages/angular/src"
},
{
"description": "This package will turn your React app into an Nx workspace. To use this package, your React app must have been generated and kept the structure of Create-React-App, with files generated either in js/jsx or ts/tsx.",
"documents": [],
"executors": [],
"generators": [],
"githubRoot": "https://github.com/nrwl/nx/blob/master",
"name": "cra-to-nx",
"packageName": "cra-to-nx",
"root": "/packages/cra-to-nx",
"source": "/packages/cra-to-nx/src"
},
{
"description": "This package is used to scaffold a brand-new workspace used to develop an Nx plugin, and sets up a pre-configured plugin with the specified name. The new plugin is created with a default generator, executor, and e2e app.",
"documents": [],
7 changes: 0 additions & 7 deletions docs/packages.json
Original file line number Diff line number Diff line change
@@ -51,13 +51,6 @@
]
}
},
{
"name": "cra-to-nx",
"packageName": "cra-to-nx",
"description": "This package will turn your React app into an Nx workspace. To use this package, your React app must have been generated and kept the structure of Create-React-App, with files generated either in js/jsx or ts/tsx.",
"path": "generated/packages/cra-to-nx.json",
"schemas": { "executors": [], "generators": [] }
},
{
"name": "create-nx-plugin",
"packageName": "create-nx-plugin",
462 changes: 0 additions & 462 deletions docs/shared/mental-model/large-tasks.json

Large diffs are not rendered by default.

11 changes: 0 additions & 11 deletions e2e/cra-to-nx/jest.config.ts

This file was deleted.

11 changes: 0 additions & 11 deletions e2e/cra-to-nx/project.json

This file was deleted.

155 changes: 0 additions & 155 deletions e2e/cra-to-nx/src/cra-to-nx.test.ts

This file was deleted.

38 changes: 0 additions & 38 deletions e2e/cra-to-nx/src/files/cra/package.json.txt

This file was deleted.

8 changes: 0 additions & 8 deletions e2e/cra-to-nx/src/files/cra/public/index.html.txt

This file was deleted.

4 changes: 0 additions & 4 deletions e2e/cra-to-nx/src/files/cra/src/App.css.txt

This file was deleted.

11 changes: 0 additions & 11 deletions e2e/cra-to-nx/src/files/cra/src/App.js.txt

This file was deleted.

8 changes: 0 additions & 8 deletions e2e/cra-to-nx/src/files/cra/src/App.test.js.txt

This file was deleted.

5 changes: 0 additions & 5 deletions e2e/cra-to-nx/src/files/cra/src/index.css.txt

This file was deleted.

13 changes: 0 additions & 13 deletions e2e/cra-to-nx/src/files/cra/src/index.js.txt

This file was deleted.

1 change: 0 additions & 1 deletion e2e/cra-to-nx/src/files/cra/src/setupTests.js.txt

This file was deleted.

62 changes: 0 additions & 62 deletions e2e/cra-to-nx/src/utils.ts

This file was deleted.

13 changes: 0 additions & 13 deletions e2e/cra-to-nx/tsconfig.json

This file was deleted.

20 changes: 0 additions & 20 deletions e2e/cra-to-nx/tsconfig.spec.json

This file was deleted.

1 change: 0 additions & 1 deletion nx-dev/data-access-menu/src/lib/menu.utils.ts
Original file line number Diff line number Diff line change
@@ -45,7 +45,6 @@ export function getPackagesSections(items: MenuItem[]): MenuSection[] {
return items
.filter(
(m) =>
m.id !== 'cra-to-nx' &&
m.id !== 'create-nx-plugin' &&
m.id !== 'create-nx-workspace' &&
m.id !== 'make-angular-cli-faster' &&
1 change: 0 additions & 1 deletion nx-dev/data-access-packages/src/lib/sort-packages.ts
Original file line number Diff line number Diff line change
@@ -30,7 +30,6 @@ export function filterMigrationPackages<ItemType extends { name: string }>(
const nxPackageNames = [
'create-nx-workspace',
'create-nx-plugin',
'cra-to-nx',
'make-angular-cli-faster',
'tao',
];
1 change: 0 additions & 1 deletion nx-dev/nx-dev-e2e/src/e2e/packages.cy.ts
Original file line number Diff line number Diff line change
@@ -96,7 +96,6 @@ describe('nx-dev: Packages Section', () => {
title: '@nrwl/angular:package',
path: '/packages/angular/executors/package',
},
{ title: 'cra-to-nx', path: '/packages/cra-to-nx' },
{ title: 'create-nx-plugin', path: '/packages/create-nx-plugin' },
{
title: 'create-nx-workspace',
1 change: 0 additions & 1 deletion nx-dev/nx-dev/pages/community.tsx
Original file line number Diff line number Diff line change
@@ -33,7 +33,6 @@ export async function getStaticProps(): Promise<{ props: CommunityProps }> {

const officialPluginList = (nxPackagesApi.getRootPackageIndex() ?? []).filter(
(m) =>
m.name !== 'cra-to-nx' &&
m.name !== 'create-nx-plugin' &&
m.name !== 'create-nx-workspace' &&
m.name !== 'make-angular-cli-faster' &&
1 change: 1 addition & 0 deletions nx-dev/nx-dev/redirect-rules.config.js
Original file line number Diff line number Diff line change
@@ -507,6 +507,7 @@ const packagesDocuments = {
'/packages/storybook/generators/migrate-7',
'/linter/eslint-plugin-nx': '/packages/linter/documents/eslint-plugin-nx',
'/packages/add-nx-to-monorepo': '/packages/nx/documents/init',
'/packages/cra-to-nx': '/packages/nx/documents/init',
};

/**
5 changes: 0 additions & 5 deletions packages/cra-to-nx/.eslintrc.json

This file was deleted.

48 changes: 0 additions & 48 deletions packages/cra-to-nx/README.md

This file was deleted.

8 changes: 0 additions & 8 deletions packages/cra-to-nx/index.ts

This file was deleted.

17 changes: 0 additions & 17 deletions packages/cra-to-nx/jest.config.ts

This file was deleted.

28 changes: 0 additions & 28 deletions packages/cra-to-nx/package.json

This file was deleted.

46 changes: 0 additions & 46 deletions packages/cra-to-nx/project.json

This file was deleted.

13 changes: 0 additions & 13 deletions packages/cra-to-nx/tsconfig.json

This file was deleted.

12 changes: 0 additions & 12 deletions packages/cra-to-nx/tsconfig.lib.json

This file was deleted.

16 changes: 0 additions & 16 deletions packages/cra-to-nx/tsconfig.spec.json

This file was deleted.

0 comments on commit 8562964

Please sign in to comment.