Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump ini from 1.3.5 to 1.3.8 in /website #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 12, 2020

This PR changes.


Review Checklist

Basics

  • PR information has been filled
  • PR has been assigned
  • PR uses appropriate labels (feature/chore/style/docs/refactor/perf/test)
  • PR has a good description that summarizes all changes
  • PR is updated to the most recent version of the target branch(and there are no conflicts)
  • PR scope(size) is manageable(feat: add helpers #1 way to speed up review time)
  • PR is peer reviewed optional
  • Commits contain a meaningful commit messages and fallow syntax of Conventional Commits
  • On dependency change: yarn.lock file is updated and committed
  • CHANGELOG.md and references to project's version are unchanged(let semantic-release do the magic)

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with TypeScript
  • Code builds(yarn build)
  • Code is formatted(yarn test:format)
  • Code is linted(yarn test:lint)
  • Code is unit tested(yarn test:unit)
  • Code is integration tested(yarn test:integration)
  • Required code coverage specification is met

Testing

  • New feature/change is covered by unit tests
  • New feature/change is covered by integration tests
  • All existing tests are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done optional

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 12, 2020
@github-actions github-actions bot requested a review from desivi December 12, 2020 23:24
@codecov-io
Copy link

Codecov Report

Merging #14 (d706df7) into master (ca13dc8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          23       23           
  Lines         161      161           
  Branches       37       37           
=======================================
  Hits          153      153           
  Misses          4        4           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2f62f...d706df7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant