Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the bottom solver default absolute tolerance #1506

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Feb 25, 2025

Summary

Update the bottom solver default absolute tolerance.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number:

@marchdf
Copy link
Contributor Author

marchdf commented Feb 26, 2025

@moprak-nrel, @mbkuhn, @jrood-nrel this causes diffs in all the tests. They are all around 1e-12. Which I would expect having changed the default bottom solver tolerance.

@marchdf marchdf marked this pull request as ready for review February 26, 2025 16:18
@marchdf marchdf merged commit f42c0cf into Exawind:main Feb 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants