Skip to content

Commit

Permalink
Revise transformation names and add docs (#802)
Browse files Browse the repository at this point in the history
* Some doc updates

* Updates

* Updates

* More updates

* Update DOLFINx tets branch

* More name updates

* Name updates

* More updates

* Stub fixes

* Split out linting test

* Install ruff

* Actions updates

* Tidy

* Remove commented code

* Doc improvements

* Update cpp/basix/precompute.h

Co-authored-by: Matthew Scroggs <[email protected]>

* Doc updates

* Doc updates

* Small doc updates

* Tidy up docs

* Small doc updates

---------

Co-authored-by: Matthew Scroggs <[email protected]>
  • Loading branch information
garth-wells and mscroggs authored Apr 19, 2024
1 parent 6099a92 commit 36663d8
Show file tree
Hide file tree
Showing 20 changed files with 857 additions and 828 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dolfinx-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
with:
path: ./dolfinx
repository: FEniCS/dolfinx
ref: main
ref: garth/transform-names-2
- name: Get DOLFINx
if: github.event_name == 'workflow_dispatch'
uses: actions/checkout@v4
Expand Down
25 changes: 19 additions & 6 deletions .github/workflows/pythonapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,25 @@ on:
workflow_dispatch:

jobs:
lint:
name: Lint code
runs-on: ubuntu-latest
steps:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.12'
- uses: actions/checkout@v4
- name: Install linting dependencies
run: pip install mypy ruff
- name: Ruff check
run: |
pip install ruff
ruff check .
ruff format --check .
- name: Mypy check
run: mypy python/basix

build:
name: Build and test
runs-on: ${{ matrix.os }}
Expand All @@ -40,12 +59,6 @@ jobs:
run: pip -v install git+https://github.com/FEniCS/ufl.git
- name: Install Basix
run: pip -v install .[ci]
- name: Ruff check
run: |
ruff check .
ruff format --check .
- name: Run mypy checks
run: mypy python/basix
- name: Run units tests
run: pytest -n auto --durations 20 test/
- name: Run simple CMake integration test
Expand Down
3 changes: 1 addition & 2 deletions cpp/basix/dof-transformations.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@
#include <utility>
#include <vector>

/// Functions to transform DOFs in high degree Lagrange spaces.
///
/// @brief Functions to transform DOFs in high degree Lagrange spaces.
/// The functions in this namespace calculate the permutations that can
/// be used to rotate and reflect DOF points in Lagrange spaces.
namespace basix::doftransforms
{

/// @brief Compute the entity DOF transformations for an element.
///
/// @param[in] cell_type The cell type
Expand Down
Loading

0 comments on commit 36663d8

Please sign in to comment.