bgpd: modify evpn advertise ipvx unicast command #18282
Open
+189
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguibert6WIND
force-pushed
the
evpn_advertise_multi_command
branch
2 times, most recently
from
08963c6 to
9208b0c
Compare
It is not possible to keep the configuration of the route-map when the advertise command is undoed to stop the service. > ubuntu2204hwe(config)# router bgp 65500 > ubuntu2204hwe(config-router)# address-family l2vpn evpn > ubuntu2204hwe(config-router-af)# advertise ipv4 unicast route-map rmap > ubuntu2204hwe(config-router-af)# no advertise ipv4 unicast > ubuntu2204hwe(config-router-af)# do show running-config > [..] > router bgp 65500 > ! > address-family l2vpn evpn > exit-address-family > [..] Propose to separate each element of the configuration in a multiple line running-configuration. The route-map and the gateway-ip option will be kept separately. Add the enable keyword to enable the service on the address-family; to keep backward compatibility with the operational behaviour, the original command will either enable or disable the service. > ubuntu2204hwe(config)# router bgp 65500 > ubuntu2204hwe(config-router)# address-family l2vpn evpn > ubuntu2204hwe(config-router-af)# advertise ipv4 unicast route-map rmap > ubuntu2204hwe(config-router-af)# advertise ipv6 unicast gateway-ip > ubuntu2204hwe(config-router-af)# do show running-config > [..] > router bgp 65500 > ! > address-family l2vpn evpn > advertise ipv4 unicast route-map rmap > advertise ipv4 unicast enable > advertise ipv6 unicast gateway-ip > advertise ipv6 unicast enable > exit-address-family > [..] > ubuntu2204hwe(config-router-af)# no advertise ipv4 unicast > ubuntu2204hwe(config-router-af)# no advertise ipv6 unicast gateway-ip > ubuntu2204hwe(config-router-af)# do show running-config > [..] > router bgp 65500 > ! > address-family l2vpn evpn > advertise ipv4 unicast route-map rmap > exit-address-family > [..] Note that the split of the command in multiple line is needed to have same behavior as yang models: this means the ability to modify distinctly each of the 3 parameters, for each address family. Signed-off-by: Philippe Guibert <[email protected]>
A multiple line configuration is put in place when setting bgp evpn advertise service. Signed-off-by: Philippe Guibert <[email protected]>
Update the description of the bgp evpn advertise command. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
evpn_advertise_multi_command
branch
from
9208b0c to
3294d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to keep the configuration of the route-map when the advertise command is undoed to stop the service.
Propose to separate each element of the configuration in a multiple line running-configuration. The route-map and the gateway-ip option will be kept separately.
Add the enable keyword to enable the service on the address-family; to keep backward compatibility with the operational behaviour, the original command will either enable or disable the service.
Note that the split of the command in multiple line is needed to comply with yang models including a container and multiple leaves.