Fixed modals sticking around for Featured Product whens section is re…

…moved in the editor (Shopify#3609)
FRTYZ · Sep 12, 2024 · 259252b · 259252b
1 parent 177a0cc
commit 259252b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/assets/global.js b/assets/global.js
@@ -619,6 +619,7 @@ class ModalDialog extends HTMLElement {
   connectedCallback() {
     if (this.moved) return;
     this.moved = true;
+    this.dataset.section = this.closest('.shopify-section').id.replace('shopify-section-', '');
     document.body.appendChild(this);
   }
 

diff --git a/assets/theme-editor.js b/assets/theme-editor.js
@@ -36,6 +36,12 @@ document.addEventListener('shopify:section:load', () => {
   }
 });
 
+document.addEventListener('shopify:section:unload', (event) => {
+  document.querySelectorAll(`[data-section="${event.detail.sectionId}"]`).forEach((element) => {
+    element.remove();
+  });
+});
+
 document.addEventListener('shopify:section:reorder', () => hideProductModal());
 
 document.addEventListener('shopify:section:select', () => hideProductModal());