Revert D17488861: constexpr type ids

Test Plan: revert-hammer Differential Revision: D17488861 Original commit changeset: ce7b059d7c86 fbshipit-source-id: 426fca9abe7122190fc17ac6976bc6bcbd5718df
FZenjoys · Oct 15, 2019 · ef8bcfe · ef8bcfe
1 parent 1865f31
commit ef8bcfe
Show file tree

Hide file tree

Showing 9 changed files with 141 additions and 385 deletions.
diff --git a/c10/test/util/ConstexprCrc_test.cpp b/c10/test/util/ConstexprCrc_test.cpp
diff --git a/c10/test/util/TypeIndex_test.cpp b/c10/test/util/TypeIndex_test.cpp
diff --git a/c10/util/ConstexprCrc.h b/c10/util/ConstexprCrc.h
diff --git a/c10/util/IdWrapper.h b/c10/util/IdWrapper.h
@@ -48,7 +48,7 @@ class IdWrapper {
   //      Fix this once we don't need GCC 4.8 anymore.
   friend constexpr bool operator==(
       const concrete_type& lhs,
-      const concrete_type& rhs) noexcept {
+      const concrete_type& rhs) {
     return lhs.id_ == rhs.id_;
   }
 
@@ -57,7 +57,7 @@ class IdWrapper {
   //      Fix this once we don't need GCC 4.8 anymore.
   friend constexpr bool operator!=(
       const concrete_type& lhs,
-      const concrete_type& rhs) noexcept {
+      const concrete_type& rhs) {
     return !(lhs == rhs);
   }
 

diff --git a/c10/util/TypeIndex.h b/c10/util/TypeIndex.h