Small fix to -[GPBEnumDescriptor getValue:forEnumTextFormatName:]

Don't look up the TextFormat for the value as aliases can trip that up, instead check the TextFormat names directly and then fetch the value.
Faire · Dec 18, 2018 · 4c55931 · 4c55931
1 parent cecba29
commit 4c55931
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/objectivec/GPBDescriptor.m b/objectivec/GPBDescriptor.m
@@ -872,11 +872,10 @@ - (BOOL)getValue:(int32_t *)outValue forEnumTextFormatName:(NSString *)textForma
     if (nameOffsets_ == NULL) return NO;
 
     for (uint32_t i = 0; i < valueCount_; ++i) {
-        int32_t value = values_[i];
-        NSString *valueTextFormatName = [self textFormatNameForValue:value];
+        NSString *valueTextFormatName = [self getEnumTextFormatNameForIndex:i];
         if ([valueTextFormatName isEqual:textFormatName]) {
             if (outValue) {
-                *outValue = value;
+                *outValue = values_[i];
             }
             return YES;
         }