prevent artefacts of large-size underscore cursor (CSI 4 SP q CSI ? 6 c)

FaisalJavedGondal · May 23, 2021 · cd5e253 · cd5e253
1 parent 8e9939a
commit cd5e253
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/wintext.c b/src/wintext.c
@@ -2374,7 +2374,7 @@ text_out(HDC hdc, int x, int y, UINT fuOptions, RECT *prc, LPCWSTR psz, int cch,
   if (*psz >= 0x80) {
     printf("@%3d (%3d):", x, y);
     for (int i = 0; i < cch; i++)
-      printf(" %04X", psz[i]);
+      printf(" %04X<%d>", psz[i], dxs[i]);
     printf("\n");
   }
 #endif
@@ -4057,8 +4057,9 @@ draw:;
             when 6: up = cell_height - 2;
           }
           if (up) {
+            int yct = max(yy - up, yt);
             HBRUSH oldbrush = SelectObject(dc, CreateSolidBrush(_cc));
-            Rectangle(dc, x, yy - up, x + char_width, yy + 2);
+            Rectangle(dc, x, yct, x + char_width, yy + 2);
             DeleteObject(SelectObject(dc, oldbrush));
           }
           else

diff --git a/wiki/Changelog.md b/wiki/Changelog.md
@@ -3,8 +3,9 @@ Terminal features
   * Alternative escape sequence DECSET 2026 for synchronous screen update (#1098).
   * Optimise screen display speed on bell sound series (#1102, ~#865).
 
-Font rendering
+Rendering
   * Speedup of width detection for auto-narrowing for certain characters (#1065, #979, #892).
+  * Prevent artefacts of large-size underscore cursor (CSI 4 SP q CSI ? 6 c).
 
 ### 3.5.0 (16 April 2021) ###