Merge pull request auth0-samples#41 from alexisluque/alexisluque-patch-1

Update CircleCI tests
FallenKochiro · Aug 13, 2018 · 801e882 · 801e882
2 parents 564ddeb + 0f54d76
commit 801e882
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -45,7 +45,7 @@ jobs:
     machine: true
     steps:
       - checkout
-      - run: git clone -b refactor-for-dotnetcore https://github.com/alexisluque/spa-quickstarts-tests scripts
+      - run: git clone https://github.com/auth0-samples/spa-quickstarts-tests scripts
       - persist_to_workspace:
           root: ~/
           paths:

diff --git a/Quickstart/01-Login/SampleMvcApp/Startup.cs b/Quickstart/01-Login/SampleMvcApp/Startup.cs
@@ -16,20 +16,22 @@ namespace SampleMvcApp
 {
     public class Startup
     {
-        public Startup(IConfiguration configuration)
+        public Startup(IConfiguration configuration, IHostingEnvironment hostingEnvironment)
         {
             Configuration = configuration;
+            HostingEnvironment = hostingEnvironment;
         }
 
         public IConfiguration Configuration { get; }
+        public IHostingEnvironment HostingEnvironment { get; }
 
         // This method gets called by the runtime. Use this method to add services to the container.
         public void ConfigureServices(IServiceCollection services)
         {
             services.Configure<CookiePolicyOptions>(options =>
             {
                 // This lambda determines whether user consent for non-essential cookies is needed for a given request.
-                options.CheckConsentNeeded = context => true;
+                options.CheckConsentNeeded = context => HostingEnvironment.IsProduction();
                 options.MinimumSameSitePolicy = SameSiteMode.None;
             });
 

diff --git a/Quickstart/02-User-Profile/SampleMvcApp/Startup.cs b/Quickstart/02-User-Profile/SampleMvcApp/Startup.cs
@@ -17,20 +17,22 @@ namespace SampleMvcApp
 {
     public class Startup
     {
-        public Startup(IConfiguration configuration)
+        public Startup(IConfiguration configuration, IHostingEnvironment hostingEnvironment)
         {
             Configuration = configuration;
+            HostingEnvironment = hostingEnvironment;
         }
 
         public IConfiguration Configuration { get; }
+        public IHostingEnvironment HostingEnvironment { get; }
 
         // This method gets called by the runtime. Use this method to add services to the container.
         public void ConfigureServices(IServiceCollection services)
         {
             services.Configure<CookiePolicyOptions>(options =>
             {
                 // This lambda determines whether user consent for non-essential cookies is needed for a given request.
-                options.CheckConsentNeeded = context => true;
+                options.CheckConsentNeeded = context => HostingEnvironment.IsProduction();
                 options.MinimumSameSitePolicy = SameSiteMode.None;
             });
 
@@ -130,4 +132,4 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env)
             });
         }
     }
-}
+}
diff --git a/Quickstart/03-Authorization/SampleMvcApp/Startup.cs b/Quickstart/03-Authorization/SampleMvcApp/Startup.cs
@@ -17,20 +17,22 @@ namespace SampleMvcApp
 {
     public class Startup
     {
-        public Startup(IConfiguration configuration)
+        public Startup(IConfiguration configuration, IHostingEnvironment hostingEnvironment)
         {
             Configuration = configuration;
+            HostingEnvironment = hostingEnvironment;
         }
 
         public IConfiguration Configuration { get; }
+        public IHostingEnvironment HostingEnvironment { get; }
 
         // This method gets called by the runtime. Use this method to add services to the container.
         public void ConfigureServices(IServiceCollection services)
         {
             services.Configure<CookiePolicyOptions>(options =>
             {
                 // This lambda determines whether user consent for non-essential cookies is needed for a given request.
-                options.CheckConsentNeeded = context => true;
+                options.CheckConsentNeeded = context => HostingEnvironment.IsProduction();
                 options.MinimumSameSitePolicy = SameSiteMode.None;
             });
 
@@ -131,4 +133,4 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env)
             });
         }
     }
-}
+}