Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all support images from the original repo #82

Closed
wants to merge 1 commit into from

Conversation

potchy
Copy link
Contributor

@potchy potchy commented Apr 26, 2020

This PR includes all CEs and Servants from the original repo.
Servants are organized by folder, as per the new structure.

I'm sure the APK size will linearly increase as we add more images, so maybe these should be distributed as a separate package instead?

@MathewSachin
Copy link
Collaborator

@potchy We're actually planning to keep the images organized in a separate repository.
We're still in the process of deciding file name conventions to avoid duplicates and all.
I'll let you know once the conventions are ready or we could handle adjusting the filenames ourselves if you're too busy and all.

@MathewSachin
Copy link
Collaborator

I've done it again. I've migrated the whole codebase to Kotlin, PR in review #108.
Xamarin C# was giving us some problems like weird errors on the latest version (Android 7.1.2) of Nox emulator.
Also, memory leaks were a pain to debug with limited support for free users of Visual Studio.

So, this app is now a proper Android app which is developed in Android Studio.
As a result, the directory structure for the project will change heavily causing even more conflicts with this PR. So, I'm closing it.

BTW, thank you for your work on the original Lua project. 👍
I'll be happy to have you here too if you got time.

@potchy potchy deleted the support-images branch August 8, 2020 15:47
@potchy potchy restored the support-images branch August 8, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants