fix: crash when create image from a empty stream

FelicePollano · Apr 8, 2024 · 8adf11b · 8adf11b
1 parent 75f6087
commit 8adf11b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Commands/QueryFileContent.cs b/src/Commands/QueryFileContent.cs
@@ -17,23 +17,23 @@ public static Stream Run(string repo, string revision, string file)
             starter.WindowStyle = ProcessWindowStyle.Hidden;
             starter.RedirectStandardOutput = true;
 
+            var stream = new MemoryStream();
             try
             {
-                var stream = new MemoryStream();
                 var proc = new Process() { StartInfo = starter };
                 proc.Start();
                 proc.StandardOutput.BaseStream.CopyTo(stream);
                 proc.WaitForExit();
                 proc.Close();
 
                 stream.Position = 0;
-                return stream;
             }
             catch (Exception e)
             {
                 App.RaiseException(repo, $"Failed to query file content: {e}");
-                return null;
             }
+
+            return stream;
         }
     }
 }
diff --git a/src/ViewModels/CommitDetail.cs b/src/ViewModels/CommitDetail.cs
@@ -475,7 +475,7 @@ private void RefreshViewRevisionFile(Models.Object file)
                             if (IMG_EXTS.Contains(ext))
                             {
                                 var stream = Commands.QueryFileContent.Run(_repo, _commit.SHA, file.Path);
-                                var bitmap = stream != null ? new Bitmap(stream) : null as Bitmap;
+                                var bitmap = stream.Length > 0 ? new Bitmap(stream) : null;
                                 Dispatcher.UIThread.Invoke(() =>
                                 {
                                     ViewRevisionFileContent = new Models.RevisionImageFile() { Image = bitmap };

diff --git a/src/ViewModels/DiffContext.cs b/src/ViewModels/DiffContext.cs
@@ -166,7 +166,7 @@ public void OpenExternalMergeTool()
         private Bitmap BitmapFromRevisionFile(string repo, string revision, string file)
         {
             var stream = Commands.QueryFileContent.Run(repo, revision, file);
-            return stream != null ? new Bitmap(stream) : null;
+            return stream.Length > 0 ? new Bitmap(stream) : null;
         }
 
         private static readonly HashSet<string> IMG_EXTS = new HashSet<string>()