Fix all static analysis problems fix alibaba#8

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcActorTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 
 static dispatch_queue_t get_test_queue(){
     static dispatch_queue_t q = nil;

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcAutoreleaseArcTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 #import <coobjc/co_autorelease.h>
 
 static int state;

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcAutoreleaseTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 #import <coobjc/co_autorelease.h>
 
 #   define RR_PUSH() objc_autoreleasePoolPush()

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcBenchmarkTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 #import "coobjcCommon.h"
 
 SpecBegin(coPerformance)

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcCancelTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 
 SpecBegin(coCancel)
 

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcChannelTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 
 
 SpecBegin(coChannel)

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcCommon.h

@@ -18,7 +18,7 @@
 
 #import <Foundation/Foundation.h>
 
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 
 @interface NSData (asyncio)
 

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcCreateTests.m

@@ -22,7 +22,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 
 /*
 SpecBegin(coCreate)

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcDelayTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 #import "coobjcCommon.h"
 
 SpecBegin(coDelay)

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcPromiseTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 
 static id testPromise1() {
 

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcSequenceTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 #import "coobjcCommon.h"
 
 SpecBegin(coSequence)

Examples/coobjcBaseExample/coobjcBaseExampleTests/coobjcTupleTests.m

@@ -21,7 +21,7 @@
 #define EXP_SHORTHAND
 #import <Expecta/Expecta.h>
 #import <OCMock/OCMock.h>
-#import <coobjc.h>
+#import <coobjc/coobjc.h>
 #import <coobjc/co_tuple.h>
 
 #ifdef DEBUG

coobjc/api/COActorChan.h

@@ -35,7 +35,7 @@ NS_ASSUME_NONNULL_BEGIN
 
  @return The actor message object.
  */
-- (COActorMessage *)next;
+- (COActorMessage *_Nullable)next;
 
 @end
 

coobjc/api/COCoroutine.h

@@ -52,7 +52,7 @@ id _Nullable co_await(id  awaitable);
  @param awaitableArray a list of awaitable
  @return the value result list. `nil` is replaced by `NSNull`.
  */
-NSArray *co_batch_await(NSArray * awaitableArray);
+NSArray *_Nullable co_batch_await(NSArray *awaitableArray);
 
 @class COCoroutine;
 
@@ -153,7 +153,7 @@ extern NSString *const COInvalidException;
  @param stackSize : stackSize of the coroutine.
  @return The coroutine object.
  */
-+ (instancetype)coroutineWithBlock:(void(^)(void))block onQueue:(dispatch_queue_t _Nullable)queue stackSize:(NSUInteger)stackSize;
++ (_Nullable instancetype)coroutineWithBlock:(void(^)(void))block onQueue:(dispatch_queue_t _Nullable)queue stackSize:(NSUInteger)stackSize;
 
 
 /**

coobjc/api/COCoroutine.m

@@ -174,7 +174,7 @@ + (instancetype)coroutineWithBlock:(void (^)(void))block onQueue:(dispatch_queue
     return [self coroutineWithBlock:block onQueue:queue stackSize:0];
 }
 
-+ (instancetype)coroutineWithBlock:(void(^)(void))block onQueue:(dispatch_queue_t _Nullable)queue stackSize:(NSUInteger)stackSize {
++ (instancetype)coroutineWithBlock:(void(^)(void))block onQueue:(dispatch_queue_t)queue stackSize:(NSUInteger)stackSize {
     if (queue == NULL) {
         queue = co_get_current_queue();
     }
@@ -361,7 +361,7 @@ id co_await(id awaitable) {
     }
 }
 
-NSArray *_Nonnull co_batch_await(NSArray * _Nonnull awaitableList) {
+NSArray *co_batch_await(NSArray * awaitableList) {
 
     coroutine_t  *t = coroutine_self();
     if (t == nil) {

coobjc/core/coroutine.m

@@ -42,8 +42,8 @@
 #pragma clang diagnostic ignored "-Wincompatible-pointer-types"
 
 
-void scheduler_add_coroutine (coroutine_list_t *l, coroutine_t *t);
-void scheduler_delete_coroutine(coroutine_list_t *l, coroutine_t *t);
+void scheduler_queue_push(coroutine_scheduler_t *scheduler, coroutine_t *co);
+coroutine_t *scheduler_queue_pop(coroutine_scheduler_t *scheduler);
 coroutine_scheduler_t *coroutine_scheduler_new(void);
 void coroutine_scheduler_free(coroutine_scheduler_t *schedule);
 void coroutine_resume_im(coroutine_t *co);
@@ -95,18 +95,16 @@ void  coroutine_memory_free(void *ptr, size_t size) {
 
 void coroutine_scheduler_main(coroutine_t *scheduler_co) {
 
-    coroutine_t *co;
     coroutine_scheduler_t *scheduler = scheduler_co->scheduler;
     for (;;) {
 
-        co = scheduler->coroutine_queue.head;
+        // pop a coroutine from queue.head.
+        coroutine_t *co = scheduler_queue_pop(scheduler);
         if (co == NULL) {
             // jump out. scheduler will enter idle.
             coroutine_yield(scheduler_co);
             continue;
         }
-        // delete from the scheduler's queue
-        scheduler_delete_coroutine(&scheduler->coroutine_queue, co);
         // set scheduler's current running coroutine.
         scheduler->running_coroutine = co;
         // resume the coroutine
@@ -203,6 +201,7 @@ void coroutine_resume_im(coroutine_t *co) {
                 // when proccess reenter(resume a coroutine), skip the remain codes, just return to pre func.
                 return;
             }
+#pragma unused(skip)
             skip = true;
 
             free(co->context);
@@ -221,6 +220,7 @@ void coroutine_resume_im(coroutine_t *co) {
                 // when proccess reenter(resume a coroutine), skip the remain codes, just return to pre func.
                 return;
             }
+#pragma unused(skip)
             skip = true;
             // setcontext
             coroutine_setcontext(co->context);
@@ -238,11 +238,11 @@ void coroutine_resume(coroutine_t *co) {
         coroutine_scheduler_t *scheduler = coroutine_scheduler_self_create_if_not_exists();
         co->scheduler = scheduler;
 
-        scheduler_add_coroutine(&scheduler->coroutine_queue, co);
+        scheduler_queue_push(scheduler, co);
 
         if (scheduler->running_coroutine) {
             // resume a sub coroutine.
-            scheduler_add_coroutine (&scheduler->coroutine_queue, scheduler->running_coroutine);
+            scheduler_queue_push(scheduler, scheduler->running_coroutine);
             coroutine_yield(scheduler->running_coroutine);
         } else {
             // scheduler is idle
@@ -262,7 +262,7 @@ void coroutine_add(coroutine_t *co) {
             main_co->scheduler = scheduler;
             scheduler->main_coroutine = main_co;
         }
-        scheduler_add_coroutine(&scheduler->coroutine_queue, co);
+        scheduler_queue_push(scheduler, co);
 
         if (!scheduler->running_coroutine) {
             coroutine_resume_im(co->scheduler->main_coroutine);
@@ -283,6 +283,7 @@ void coroutine_yield(coroutine_t *co)
     if (skip) {
         return;
     }
+#pragma unused(skip)
     skip = true;
     co->status = COROUTINE_SUSPEND;
     coroutine_setcontext(co->pre_context);
@@ -299,32 +300,32 @@ void coroutine_yield(coroutine_t *co)
 
 #pragma mark - linked lists
 
-// add routine to the queue
-void scheduler_add_coroutine(coroutine_list_t *l, coroutine_t *t) {
-    if(l->tail) {
-        l->tail->next = t;
-        t->prev = l->tail;
+void scheduler_queue_push(coroutine_scheduler_t *scheduler, coroutine_t *co) {
+    coroutine_list_t *queue = &scheduler->coroutine_queue;
+    if(queue->tail) {
+        queue->tail->next = co;
+        co->prev = queue->tail;
     } else {
-        l->head = t;
-        t->prev = nil;
+        queue->head = co;
+        co->prev = nil;
     }
-    l->tail = t;
-    t->next = nil;
+    queue->tail = co;
+    co->next = nil;
 }
 
-// delete routine from the queue
-void scheduler_delete_coroutine(coroutine_list_t *l, coroutine_t *t) {
-    if(t->prev) {
-        t->prev->next = t->next;
-    } else {
-        l->head = t->next;
-    }
-
-    if(t->next) {
-        t->next->prev = t->prev;
-    } else {
-        l->tail = t->prev;
+coroutine_t *scheduler_queue_pop(coroutine_scheduler_t *scheduler) {
+    coroutine_list_t *queue = &scheduler->coroutine_queue;
+    coroutine_t *co = queue->head;
+    if (co) {
+        queue->head = co->next;
+        // Actually, co->prev is nil now.
+        if (co->next) {
+            co->next->prev = co->prev;
+        } else {
+            queue->tail = co->prev;
+        }
     }
+    return co;
 }
 
 #pragma clang diagnostic pop

coobjc/objc/co_autorelease.mm

@@ -330,7 +330,7 @@ void kill()
                     page->protect();
                 }
                 delete deathptr;
-            } while (deathptr != this);
+            } while (deathptr != this && page != nil);
         }
 
         static void routine_dealloc(void *p)
@@ -658,7 +658,7 @@ static BOOL co_is_autoreleasepage(void *ctx){
     uintptr_t address = (uintptr_t)ctx;
     uintptr_t baseAddress = (address / PAGE_MAX_SIZE) * PAGE_MAX_SIZE;
     COAutoreleasePoolPage *page = (COAutoreleasePoolPage*)baseAddress;
-    if (page->bitMask == (uintptr_t)CO_AUTORELEASE_PAGE_MASK) {
+    if (page && page->bitMask == (uintptr_t)CO_AUTORELEASE_PAGE_MASK) {
         return YES;
     }
     return NO;

coobjc/objc/co_tuple.h

@@ -18,7 +18,7 @@
 
 #import <Foundation/Foundation.h>
 
-@interface COTuple : NSObject<NSCopying, NSFastEnumeration>
+@interface COTuple : NSObject<NSFastEnumeration>
 
 // Creation
 - (id)init; // Empty tuple

coobjc/objc/co_tuple.m

@@ -111,11 +111,11 @@ - (id)initWithObjects:(id)objects, ... {
 }
 
 // Protocolic Obligations
-- (id)copyWithZone:(NSZone *)zone {
-    id newtup = [[[self class] alloc] init];
-    [newtup _setStorage:[[self _storage] copy]];
-    return newtup;
-}
+//- (id)copyWithZone:(NSZone *)zone {
+//    id newtup = [[[self class] alloc] init];
+//    [newtup _setStorage:[[self _storage] copy]];
+//    return newtup;
+//}
 - (NSUInteger)countByEnumeratingWithState:(NSFastEnumerationState *)state objects:(id arc_unsafe_unretained [])stackbuf count:(NSUInteger)len {
     return [storage countByEnumeratingWithState:state objects:stackbuf count:len];
 }