Skip to content

Commit

Permalink
Change canary back to start both worker and starter by default (caden…
Browse files Browse the repository at this point in the history
  • Loading branch information
longquanzheng authored Oct 20, 2021
1 parent a3fdf4c commit 942f032
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
11 changes: 7 additions & 4 deletions canary/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ In the `docker/` directory, run:
```
docker-compose -f docker-compose-canary.yml up
```

This will start the canary worker and also the cron canary.

You can modify [the canary worker config](../docker/config/canary/development.yaml) to run against a prod server cluster:
* Use a different mode to start canary worker only for testing
* Update the config to use Thrift/gRPC for communication
Expand All @@ -38,21 +41,21 @@ In the project root, build cadence canary binary:
make cadence-canary
```

Then start canary worker:
Then start canary worker & cron:
```
./cadence-canary start
```
This is essentially the same as
```
./cadence-canary start -mode worker
./cadence-canary start -mode all
```

By default, it will load [the configuration in `config/canary/development.yaml`](../config/canary/development.yaml).
Run `./cadence-canary -h` for details to understand the start options of how to change the loading directory if needed.

This will only start the workers. To start both workers and cron starter:
To start the worker only for manual testing certain cases:
```
./cadence-canary start -mode all
./cadence-canary start -mode worker
```

### 3. Monitoring
Expand Down
2 changes: 1 addition & 1 deletion cmd/canary/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func buildCLI() *cli.App {
Flags: []cli.Flag{
cli.StringFlag{
Name: "mode, m",
Value: canary.ModeWorker,
Value: canary.ModeAll,
Usage: fmt.Sprintf("%v, %v or %v", canary.ModeWorker, canary.ModeCronCanary, canary.ModeAll),
EnvVar: canary.EnvKeyMode,
},
Expand Down

0 comments on commit 942f032

Please sign in to comment.