Send copies of vertexes instead of pointers to changing vertices pt 2 electric boogaoo + some other rendering stuff maybe? #296
Conversation
| public Float x,y,z; | ||
| public Float r,g,b,a; | ||
| public Float uvX,uvY; | ||
| public int overlay; | ||
| public int light; | ||
| public Float nX,nY,nZ; | ||
| public boolean consumed; |
There was a problem hiding this comment.
any reason these are capital Float (the box type) instead of lowercase float (the primitive)? none of them look nullable to me
There was a problem hiding this comment.
Typo, Used to other languages using Float instead of float
| @@ -181,8 +180,7 @@ protected PartCustomization setupRootCustomization(double vertOffset) { | |||
| customization.setPrimaryRenderType(RenderTypes.TRANSLUCENT); | |||
| customization.setSecondaryRenderType(RenderTypes.EMISSIVE); | |||
|
|
|||
| double s = 1.0 / 16; | |||
| customization.positionMatrix.scale(s, s, s); | |||
| customization.positionMatrix.scale(0.0625, 0.0625, 0.0625); | |||
There was a problem hiding this comment.
Either add a comment explaining why the 0.0625, that is clarify it stands for 1 / 16, or undo the change. The compiler or jvm probably inline this anyway because it's a constant so it's an unnecessary change that makes it less clear and makes changes in the future harder because no one will know what 0.062 is or stands for.
| int sky = l.getBrightness(LightLayer.SKY, pos.asBlockPos()); | ||
| customizationStack.peek().light = LightTexture.pack(block, sky); | ||
| var pos = part.savedPartToWorldMat.apply(0d, 0d, 0d).asBlockPos(); | ||
| customizationStack.peek().light = LightTexture.pack(l.getBrightness(LightLayer.BLOCK, pos), l.getBrightness(LightLayer.SKY, pos)); |
There was a problem hiding this comment.
Don't use things such as var, this is not JS and I have to back port all these changes to Java 8 later, there's no good reason to. Also why inline these? They're locals and get destroyed after they go out of scope anyway, it's not optimizing anything
| @@ -542,32 +529,81 @@ private void pushToBuffer(int faceCount, VertexData vertexData, PartCustomizatio | |||
|
|
|||
| int overlay = customization.overlay; | |||
| int light = vertexData.fullBright ? LightTexture.FULL_BRIGHT : customization.light; | |||
| ToBeConsumedVertexData[] vertexDatas = new ToBeConsumedVertexData[vertCount]; // why the fuck did i use duckai for this | |||
There was a problem hiding this comment.
Please provide a visual example of what the change is actually fixing or doing, I understand you're "copying" the data to consume it later but it is less than clear why you are doing so. Explain why the vertices change, etc.
|
This doesn't actually fix the issue at the moment, the requested changes have been made but I don't have enough time at the moment to fix the issue :c_:, I'll push the changes when it's done |
pull/295 but less bad maybe