Fix for CoapEndpointSpec test when transport becomes not ready #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the test
rejects requests when transport becomes not ready after requests startedto change the response delay time which fixes the race condition.By setting the response to return after the test timeout, we ensure that the test has enough time to receive the notReady signal. Otherwise you can get an incorrect response due to the notReady signal and default response time being very close. This doesn't increase the time the test will run because the notReady signal is sent in 20ms. The longest time this test could run is 10s, but that is only if the signal fails to be sent and captured correctly (aka a completely broken test).
This PR also re-enables the test so it will start executing on the CI.