physic: Change parseError.Error() formatting (google#314)

Add option for no original string.
FivePente · Nov 7, 2018 · 118880d · 118880d
1 parent 8508d47
commit 118880d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/conn/physic/units.go b/conn/physic/units.go
@@ -991,6 +991,9 @@ func (p *parseError) Error() string {
 	if p.err == nil {
 		return "parse error"
 	}
+	if p.s == "" {
+		return "parse error: " + p.err.Error()
+	}
 	return "parse error: " + p.err.Error() + ": \"" + p.s + "\""
 }
 

diff --git a/conn/physic/units_test.go b/conn/physic/units_test.go
@@ -727,7 +727,7 @@ func TestParseError(t *testing.T) {
 		want string
 	}{
 		{"empty", &parseError{s: "", err: nil}, "parse error"},
-		{"empty", &parseError{s: "", err: errors.New("test")}, "parse error: test: \"" + "\""},
+		{"empty", &parseError{s: "", err: errors.New("test")}, "parse error: test"},
 		{"noUnits", noUnits("someunit"), "parse error: no units provided, need: \"someunit\""},
 	}
 	for _, tt := range tests {