refactor(*): simplify methods for adding and removing words

web-mech#45 web-mech#45
Fl4sh10 · Oct 23, 2018 · 2269656 · 2269656
1 parent 1ab43a8
commit 2269656
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/lib/badwords.js b/lib/badwords.js
@@ -77,8 +77,8 @@ var Filter = (function () {
    * Add words to blacklist filter / remove words from whitelist filter
    * @param {(string|string[])}
    */
-  Filter.prototype.addWords = function addWords(words) {
-    words = (words instanceof Array) ? words : [words];
+  Filter.prototype.addWords = function addWords() {
+    let words = Array.from(arguments);
     this.list = this.list.concat(words);
 
     words.forEach(function (word) {
@@ -90,10 +90,10 @@ var Filter = (function () {
 
   /**
    * Add words to whitelist filter
-   * @param {...string} word - Word to add to whitelist.
+   * @param {(string|string[])} word - Word to add to whitelist.
    */
   Filter.prototype.removeWords = function removeWords() {
-    var words = Array.prototype.slice.call(arguments);
+    let words = Array.from(arguments);
     this.exclude.push.apply(this.exclude, words);
   };
 

diff --git a/test/removeWords.js b/test/removeWords.js
@@ -6,7 +6,8 @@ var Filter = require('../lib/badwords.js'),
 describe('filter', function(){
   describe('removeWords',function(){
     it("Should allow you to remove words from the filter blacklist and no longer filter them",function(){
-      filter.removeWords('hells');
+      let removingWords = ['hells', 'yea'];
+      filter.removeWords(...removingWords);
       assert(filter.clean('This is a hells good test') === 'This is a hells good test');
       filter.addWords('hells');
       assert(filter.clean('This is a hells good test') === 'This is a ***** good test');