conversations: remember last seen timestamps

[aviau]

Or user won't see the message.

[aviau]

@isra17 review plz

[aviau]

ping @isra17!

After our discussion, I have implemented persistent timestamps.

It looks like this in the buddylist:

            <chat proto='prpl-flare-icq' account='+censored'>
                <alias>Salut</alias>
                <component name='group'>Conferences</component>
                <component name='title'>Salut</component>
                <component name='state'>joined</component>
                <component name='sn'>[email protected]</component>
                <setting name='gtk-mute-sound' type='bool'>0</setting>
                <setting name='last_seen_timestamp' type='string'>1576258436</setting>
            </chat>

I use strings for the timestamp because they are int64.

[isra17]

            NonNull::new(c_str)
            .map(|p| {
                CStr::from_ptr(p.as_ptr() as *const c_char)
                    .to_str()
                    .unwrap()
            })

? (This would return an Option<&str>)

[aviau]

I can't seem to create the NonNull with the c_value.

Am I doing something wrong?

    pub fn get_string(&mut self, key: &str) -> Option<&str> {
        let c_key = CString::new(key).unwrap();
        let mut c_value =
            unsafe { purple_sys::purple_blist_node_get_string(self.0.as_ptr(), c_key.as_ptr()) };

        NonNull::new(c_value).map(|p| {
            CStr::from_ptr(p.as_ptr() as *const c_char)
                .to_str()
                .unwrap()
        })
    }

   = note: expected raw pointer `*mut _`
              found raw pointer `*const i8`

[isra17]

Just add NonNull::new(c_value as *mut c_char) I believe.

[aviau]

Done!

[isra17]

LGTM!