Skip to content

Commit

Permalink
fix talib bug on bollinger bands and other indicators when working on…
Browse files Browse the repository at this point in the history
… small assets, rise talib prescision and add test associated
  • Loading branch information
Axel-CH committed Aug 5, 2018
1 parent a2730cd commit 0b825e9
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 2 deletions.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ RUN apt-get update && apt-get -y install curl build-essential && apt-get clean
RUN curl -L http://prdownloads.sourceforge.net/ta-lib/ta-lib-0.4.0-src.tar.gz | \
tar xzvf - && \
cd ta-lib && \
sed -i "s|0.00000001|0.000000000000000001 |g" src/ta_func/ta_utility.h && \
./configure && make && make install && \
cd .. && rm -rf ta-lib
ENV LD_LIBRARY_PATH /usr/local/lib
Expand Down
15 changes: 15 additions & 0 deletions freqtrade/tests/test_talib.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@


import talib.abstract as ta
import pandas as pd

def test_talib_bollingerbands_near_zero_values():
inputs = pd.DataFrame([
{'close': 0.00000010},
{'close': 0.00000011},
{'close': 0.00000012},
{'close': 0.00000013},
{'close': 0.00000014}
])
bollinger = ta.BBANDS(inputs, matype=0, timeperiod=2)
assert (bollinger['upperband'][3] != bollinger['middleband'][3])
8 changes: 6 additions & 2 deletions install_ta-lib.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
if [ ! -f "ta-lib/CHANGELOG.TXT" ]; then
tar zxvf ta-lib-0.4.0-src.tar.gz
cd ta-lib && ./configure && make && sudo make install && cd ..
cd ta-lib && \
sed -i "s|0.00000001|0.000000000000000001 |g" src/ta_func/ta_utility.h && \
./configure && make && sudo make install && cd ..
else
echo "TA-lib already installed, skipping download and build."
cd ta-lib && sudo make install && cd ..
cd ta-lib && \
sed -i "s|0.00000001|0.000000000000000001 |g" src/ta_func/ta_utility.h && \
sudo make install && cd ..
fi

0 comments on commit 0b825e9

Please sign in to comment.