-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds and runs on Swift 3 #24
base: master
Are you sure you want to change the base?
Conversation
Builds on Xcode 8.3beta2 with zero warnings. Runs on iOS 10.3 (14E5230e)
Hi Alex, Thanks a million for this. Because of the terms of employment with my new employer, I need to get approval to merge your changes. I've noticed a few issues - default NSNumber* values seem a bit funky on some of the custom filters and the Metal based filters crash (I'd like to move those to the new CI image processor). I'll try to find time to look at those issues and get your merge signed off 🙂 Thanks again! Simon *Yep - looks like having parameters as |
Hi. This fixes one bug in I don't know the expected behavior of the app everywhere, so I'm not sure how to look for all other cases of this sort of problem systematically. I'm not 100% sure what is going on. But the key thing, I think, is that whenever one is setting a value of a dictionary that will be consumed by CoreImage, to assign an And weirdly, trying |
If you can give me a pointer about what to look for to find other places that need some of these casting fixes, I'm happy to chase them down. On second thought, I'm not sure why the |
Hello. Love your book. (We met briefly at a conference a while ago, btw.)
Anyway, I've updated the project so it builds on Swift 3 with zero errors or warnings.
I have not rigorously tested this. I just wanted to get it running so I could play with it. But it seems to work.
Mostly this was automatic updates except for the following manual changes: