Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rekey and close remainder to checks #25

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Add rekey and close remainder to checks #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7993ad
Add rekey and close remainder to checks
gidonkatten Nov 22, 2023
745677f
Changed to patch
gidonkatten Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-bananas-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@folks-router/js-sdk": patch
---

Add additional checks for rekey and close remainder to for pay/asset transaction
2 changes: 2 additions & 0 deletions packages/folks-router-js-sdk/src/FolksRouterClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ export class FolksRouterClient {
const swapEndTxn = unsignedTxns[unsignedTxns.length - 1]!;

// send algo/asset
if (sendAssetTxn.reKeyTo !== undefined) throw Error("Unexpected rekey");
if (sendAssetTxn.closeRemainderTo !== undefined) throw Error("Unexpected close remainder to");
if (encodeAddress(sendAssetTxn.to.publicKey) !== folksRouterAddr) throw Error("Incorrect receiver");
if (
!(fromAssetId === 0 && sendAssetTxn.type == TransactionType.pay) &&
Expand Down