Skip to content

Commit

Permalink
remove commented code and TODO as it's not actually possible (bevyeng…
Browse files Browse the repository at this point in the history
…ine#2289)

Fixing it was tried in bevyengine#2069 and deemed not possible (bevyengine#2069 (comment))

Other possibility would be to change the TODO to note the dependency on chalk integration.
  • Loading branch information
mockersf committed Jun 2, 2021
1 parent 0b67084 commit 6301b72
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions crates/bevy_ecs/src/query/filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,6 @@ use crate::{
use bevy_ecs_macros::all_tuples;
use std::{cell::UnsafeCell, marker::PhantomData, ptr};

// TODO: uncomment this and use as shorthand (remove where F::Fetch: FilterFetch everywhere) when
// this bug is fixed in Rust 1.51: https://github.com/rust-lang/rust/pull/81671
// pub trait QueryFilter: WorldQuery
// where
// Self::Fetch: FilterFetch,
// {
// }

// impl<T: WorldQuery> QueryFilter for T where T::Fetch: FilterFetch {
// }

/// Extension trait for [`Fetch`] containing methods used by query filters.
/// This trait exists to allow "short circuit" behaviors for relevant query filter fetches.
pub trait FilterFetch: for<'a> Fetch<'a> {
Expand Down

0 comments on commit 6301b72

Please sign in to comment.