-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add of the aggregation functionnality #1389
base: master
Are you sure you want to change the base?
Conversation
give the MR a sensible name and fix the tests |
I have updated the function, what can I do about the tests ? |
the name of the merge request here is still "first commit"... not very explicit... The tests? if you click on the failing pipelines over you can see that it is lintingt failing. so try to run "ruff" on you code and fix the errors it gives you |
I just read the details, but can't figure out how to solve them. can someone help ? |
Knowing that I did the tests locally and the function worked with no errors. |
next step is to install ruff and run it on your code. It show clearly at least one error |
you have a proble on your system then. but then you can also use the output of the CI on gihub: https://github.com/FreeOpcUa/opcua-asyncio/actions/runs/5936420662/job/16096791948?pr=1389 what needs fixing is quite clear |
The aim of this pull request is to add the functionality of requesting aggregates from the server using the "ReadProcessedDetails" low level function by adding a high level function "Read_processed_history" similar to the "Read_raw_history" high level function.